Repository navigation
Remove stale steps and conditions from CI workflows - #3180
Merged
Merged
Conversation
- `conda-package.yml`: the upload job also allowed `release*` branches and tags, but the workflow triggers only on pushes to `master` and on PRs, so those branches never fire; the condition is now just a `master` push in `IntelPython/dpnp`. - `conda-package.yml`: the Array API job ran `sudo apt-get install jq`, but `jq` comes preinstalled on the runner image (`jq is already the newest version (1.8.1-4ubuntu2)` on `ubuntu-26.04`). It also ran "List installed packages" and "Smoke test" a second time after `pip install -r requirements.txt`, which adds only test plugins (hypothesis, ndindex, pytest-json-report). - `cron-run-tests.yaml`: the comment on the schedule was copied from the Scorecard workflow; this workflow tests the package of the latest tag nightly. - `build-sphinx.yml`: drop the "Dump GitHub context" debug step, which printed the whole event payload on every docs run.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 8, 2026 18:23
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev1=np2py314h8d9cdd5_16 ran successfully. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the CI workflow cleanup.
No open issues 🎉
What changed in this PR
This PR removes redundant CI steps and unreachable upload conditions while preserving the workflows’ intended behavior.
Changes:
- Simplifies package uploads to
masterinIntelPython/dpnpand removes redundant Array API setup and checks. - Removes the full GitHub context dump from documentation builds.
- Corrects the nightly test schedule comment without changing its behavior.
| File | Description |
|---|---|
.github/workflows/cron-run-tests.yaml |
Corrects the comment describing nightly tests of the latest tagged package. |
.github/workflows/conda-package.yml |
Simplifies upload conditions and removes unnecessary jq installation and duplicate checks. |
.github/workflows/build-sphinx.yml |
Removes the GitHub context debug output. |
Review effort: Balanced
Collaborator
|
coverage: 84.467%. remained the same — remove-stale-ci-steps into master |
vlad-perevezentsev
approved these changes
Nov 11, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
github-actions Bot
added a commit
that referenced
this pull request
Nov 12, 2026
Removes CI steps and conditions that no longer do anything: - `conda-package.yml`: the upload job also allowed `release*` branches and tags, but the workflow triggers only on pushes to `master` and on PRs, so those never fire. The condition is now just a `master` push in `IntelPython/dpnp`. - `conda-package.yml`: the Array API job ran `sudo apt-get install jq`, but `jq` comes preinstalled on the runner image (`jq is already the newest version (1.8.1-4ubuntu2)` on `ubuntu-26.04`). It also ran "List installed packages" and "Smoke test" a second time after `pip install -r requirements.txt`, which adds only test plugins (hypothesis, ndindex, pytest-json-report); the first pair stays. - `cron-run-tests.yaml`: the comment on the schedule was copied from the Scorecard workflow. This workflow tests the package of the latest tag nightly. - `build-sphinx.yml`: drops the "Dump GitHub context" debug step, which printed the whole event payload on every docs run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes CI steps and conditions that no longer do anything:
conda-package.yml: the upload job also allowedrelease*branches and tags, but the workflow triggers only on pushes tomasterand on PRs, so those never fire. The condition is now just amasterpush inIntelPython/dpnp.conda-package.yml: the Array API job ransudo apt-get install jq, butjqcomes preinstalled on the runner image (jq is already the newest version (1.8.1-4ubuntu2)onubuntu-26.04). It also ran "List installed packages" and "Smoke test" a second time afterpip install -r requirements.txt, which adds only test plugins (hypothesis, ndindex, pytest-json-report); the first pair stays.cron-run-tests.yaml: the comment on the schedule was copied from the Scorecard workflow. This workflow tests the package of the latest tag nightly.build-sphinx.yml: drops the "Dump GitHub context" debug step, which printed the whole event payload on every docs run.Checklist