Skip to content

Correct the Dependabot note about the dpctl floor - #3171

Open
antonwolfy wants to merge 5 commits into
masterfrom
dependabot-ignore-dpctl
Open

antonwolfy wants to merge 5 commits into
masterfrom
dependabot-ignore-dpctl

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Dependabot opened #3166 to raise dpctl>=0.23.0dev0 in environments/dpctl_pkg.txt to >=0.23.0 once dpctl 0.23.0 was released, although the note in .github/dependabot.yml says >= floors and dev pre-releases are not bumped. On master that floor tracks the dpctl dev series together with pyproject.toml, environments/dpctl_pkg.yml and the conda recipes, so such a PR is not meant to be merged. It is the signal to bump dpctl to the next dev series by hand in all those places, as #3169 does.

This PR replaces the incorrect note with that rule and adds it to .github/AGENTS.md.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy changed the title Stop Dependabot from bumping the dpctl floor Correct the Dependabot note about the dpctl floor Nov 7, 2026
@antonwolfy antonwolfy self-assigned this Nov 7, 2026
@antonwolfy antonwolfy added this to the 0.22.0 release milestone Nov 7, 2026
@antonwolfy
antonwolfy requested a balanced review from Copilot November 7, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The version-pin instructions need to preserve release-only build requirements in pyproject.toml and conda-recipe-cf/meta.yaml, with the same clarification in .github/dependabot.yml, to avoid requiring unavailable development versions.

1 open issue
What changed in this PR

This documentation-only PR corrects the guidance for handling Dependabot updates to dpnp’s dpctl development-version floor, following #3166 and the coordinated update in #3169.

Changes:

  • Replaces the incorrect claim that Dependabot does not bump minimum versions or development prereleases.
  • Documents that release-triggered dpctl PRs should prompt a coordinated manual update rather than be merged directly.
  • Leaves dependency versions and Dependabot configuration behavior unchanged.
File Description
.github/​dependabot.yml Corrects the comment describing how to handle dpctl release updates.
.github/​AGENTS.md Adds contributor guidance for coordinated manual dpctl updates.

Review effort: Balanced

Comment thread .github/AGENTS.md Resolved
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.22.0dev1=np2py314h8d9cdd5_20 ran successfully.
Passed: 1491
Failed: 0
Skipped: 6

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/3171/index.html

@coveralls

coveralls commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 84.397%. remained the same — dependabot-ignore-dpctl into master

@antonwolfy
antonwolfy requested a balanced review from Copilot November 8, 2026 12:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for this documentation-only clarification of Dependabot’s dpctl update guidance.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@vlad-perevezentsev vlad-perevezentsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants