Repository navigation
Don't declare the xml prefix on aggregate roots - #353
Merged
Merged
Conversation
entitiesdescriptor() copied the whole NS map onto the EntitiesDescriptor root, which emitted an explicit xmlns:xml declaration. The xml prefix is implicitly bound and must never be declared. libxml2 ignores the declaration when canonicalizing, but .NET's SignedXml keeps it, so a signed aggregate failed to verify in ADFSToolkit although xmlsec1 and other libxml2-based verifiers accepted it. Drop the prefix from the nsmap before building the root, and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entitiesdescriptor() copied the whole NS map onto the EntitiesDescriptor root, which emitted an explicit xmlns:xml declaration. The xml prefix is implicitly bound and must never be declared. libxml2 ignores the declaration when canonicalizing, but .NET's SignedXml keeps it, so a signed aggregate failed to verify in ADFSToolkit although xmlsec1 and other libxml2-based verifiers accepted it.
Drop the prefix from the nsmap before building the root, and add a regression test.