Repository navigation
feat: expose collection guestbook inheritance setting - #508
Draft
ChengShi-1 wants to merge 1 commit into
Draft
ChengShi-1 wants to merge 1 commit into
ChengShi-1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Expose optional
guestbookRootthrough the existinggetCollection,createCollection, andupdateCollectionuse cases so consumers can read and persist the collection's guestbook inheritance setting. A partial update containing only{ guestbookRoot: false }includes parent guestbooks;truestops inheritance. Omitted values remain omitted for older-server compatibility and leave the setting unchanged during updates.Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
This extends the collection model and DTO rather than adding separate endpoints or use cases.
guestbookRootis the inverse of the UI's "include guestbooks from parent collections" checkbox. The branch is based ondevelopand contains only this feature and its tests/documentation.Suggestions on how to test this:
run:
npm run test:unit -- --runInBand test/unit/collections npm run test:integration -- --runInBand test/integration/collections/CollectionsRepository.test.ts -t guestbookRoot npm run test:functional -- --runInBand test/functional/collections/UpdateCollection.test.ts -t 'guestbook inheritance'Is there a release notes or changelog update needed for this change?:
Added an entry under
CHANGELOG.mdAdditional documentation:
Updated
docs/useCases.mdfor collection reads, creation, and partial updates, including the boolean semantics and required backend version.