Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At startup, DiskQuotaMonitor traverses the cache of every layer whose saved usage is zero, to compute it (assuming they are new/untracked). A quota store that discards usage (like DummyQuotaStore in GeoServer) reports zero for every layer, so the monitor walks the whole tile cache and then throws the result away. GeoServer installs that store while the disk quota is disabled, which is the default. On a large cache on network storage the traversal takes hours of CPU and file system load, and it runs again at every disk quota save and every GWC reload.
In this PR, QuotaStore gets a default method,
tracksUsage(), that returns true. When the store returns false, the monitor skips the traversal. The BDB and JDBC stores keep the default, so standalone GWC behaves as beforewith the quota disabled it still records usage, as the disk quota documentation describes.