Repository navigation
Conversation
The NS2 server console accepts input: sv_say is a stock admin command (no Shine needed) and shows in chat as "Admin: <message>". Set consoleinteract to yes, which also enables the send command, and add sv_say as the ns2 warning command so warnplayerstimer works. Fixes #5240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds in-game player warnings (
warnplayerstimer) for Natural Selection 2.ns2serverhadconsoleinteract="no", so warnings were skipped as "not supported" and thesendcommand was blocked. The NS2 server console does take input, andsv_sayis a stock NS2 admin command (no Shine needed) that prints to every player's chat asAdmin: <message>.Changes:
ns2server/_default.cfg:consoleinteract="yes". This also enables./ns2server send.command_stop.sh:sv_say %sas the warning command forns2.Shine users who want a centred message can still use
sendwithsh_csay, but warnings usesv_sayso they work on a stock server.NS2: Combat (
ns2cserver) is not changed: its console could not be tested here, so it keepsconsoleinteract="no".Fixes #5240
Affected servers: ns2
Type of change
Testing
ns2server, typed into its tmux console the same wayfn_stop_warn_players_senddoes (send-keys -l "<text>"thenENTER):sv_say LinuxGSM console test, an unknown command as a negative test, andsv_status.sv_saywas run as an admin command and printedChat All - Admin: LinuxGSM console test, with spaces intact.sv_statuswas run as an admin command too. The unknown command was echoed but did nothing, as expected. No Shine on that server.Risk and rollback
warnplayerstimeris set)Breaking changes
Documentation
Checklist
PR will not be merged until all steps are complete.
Thank you for your Pull Request!