Repository navigation
Give MappingQueryFbFixture its own test store. - #1297
Open
niekschoemaker wants to merge 1 commit into
Open
niekschoemaker wants to merge 1 commit into
niekschoemaker wants to merge 1 commit into
Conversation
MappingQueryFixtureBase uses the "Northwind" store name with a reduced model. FbTestStore creates a shared store from the model of the first fixture that uses it, so whenever MappingQueryFbTest happened to run before the Northwind tests, EFCore_Northwind.fdb was created without e.g. Products and Customers.City and every Northwind test failed with "Column unknown"/"Table unknown". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
niekschoemaker
marked this pull request as ready for review
November 4, 2026 15:26
Contributor
Author
|
This still doesn't explain why it hangs, it does explain why it fails, but maybe the failure is also what causes the hang, but that's something that time will tell, as flaky tests are quite difficult to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MappingQueryFixtureBase uses the "Northwind" store name with a reduced model. FbTestStore creates a shared store from the model of the first fixture that uses it, so whenever MappingQueryFbTest happened to run before the Northwind tests, EFCore_Northwind.fdb was created without e.g. Products and Customers.City and every Northwind test failed with "Column unknown"/"Table unknown".
I noticed some tests randomly hang/fail, so decided to let AI dig through the enormous log files to figure out if there's any pattern that could cause the flaky tests, and it found that whenever MappingQueryFbTest runs before the Northwind tests all the northwind tests would fail.
The tests were writen for SQL Server which uses a script to generate the database, so SQL Server doesn't run into this issue, but since this provider use EnsureCreatedAsync the tests would fail whenever MappingQuery runs before the Northwind tests. So with some luck this should fix the random test failures and hangs.