Repository navigation
Support type mappings in NativeAOT compiled models. - #1295
Open
niekschoemaker wants to merge 1 commit into
Open
niekschoemaker wants to merge 1 commit into
niekschoemaker wants to merge 1 commit into
Conversation
dotnet ef dbcontext optimize --nativeaot failed because the Firebird type mappings had no public static Default property. Every Fb*TypeMapping now has one. The generated code recreates a mapping as Default.Clone(...) from the standard RelationalTypeMappingParameters only, so FbDateTimeTypeMapping, FbStringTypeMapping and FbTimeSpanTypeMapping additionally expose FbDbType and Clone(FbDbType), and the new FbCSharpRuntimeAnnotationCodeGenerator emits that Clone when the FbDbType differs from the one of Default (e.g. DATE vs TIMESTAMP, CHAR vs VARCHAR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
niekschoemaker
marked this pull request as ready for review
November 4, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet ef dbcontext optimize --nativeaot failed because the Firebird type mappings had no public static Default property. Every Fb*TypeMapping now has one.
The generated code recreates a mapping as Default.Clone(...) from the standard RelationalTypeMappingParameters only, so FbDateTimeTypeMapping, FbStringTypeMapping and FbTimeSpanTypeMapping additionally expose FbDbType and Clone(FbDbType), and the new FbCSharpRuntimeAnnotationCodeGenerator emits that Clone when the FbDbType differs from the one of Default (e.g. DATE vs TIMESTAMP, CHAR vs VARCHAR).
The solutions employed here follow the same approach as the postgresql provider. So the generation of the Clone method when the type mapping isn't the exact mapping from Default.
This code has been generated by AI, and was manually reviewed by me.
I think this also covers a small part of issue #1096, but only the part where precompiled queries and models from efcore will work.