Repository navigation
Conversation
cincuranet
approved these changes
Nov 4, 2026
alaricd
force-pushed
the
fix/octets-field-type-contract
branch
from
November 4, 2026 13:50
a62ee5b to
929cf74
Compare
alaricd
force-pushed
the
fix/octets-field-type-contract
branch
from
November 5, 2026 12:45
929cf74 to
651fa8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1286.
Root cause
GetFieldTypemapped CHAR/VARCHAR fields tostringregardless of charset.GetValuereturnsbyte[]for fields using the OCTETS character set, so the two disagreed.Change
GetFieldTypereturnsbyte[]for CHAR/VARCHAR fields using the OCTETS character set, matchingGetValue. The existing Guid mapping is unchanged.Tests
GetFieldTypeMatchesGetValueForOctetsTest: fails without the fix (Expected: byte[]).Verification gaps
AI disclosure
This change was prepared with AI assistance (Claude Code).
🤖 Generated with Claude Code