Repository navigation
Fix payment failinfo groupid - #9734
Open
daywalker90 wants to merge 2 commits into
Open
daywalker90 wants to merge 2 commits into
daywalker90 wants to merge 2 commits into
Conversation
wallet_payment_set_failinfo() matches on payment_hash and partid but not groupid, so when a retry in a new group fails, its failure details overwrite those of every earlier failed group with the same partid. A waitsendpay for the earlier group then reports the newer error.
wallet_payment_set_failinfo() matched rows on payment_hash and partid only, a leftover from before groupid became part of the payments key. Every failed retry in a new group therefore overwrote the failure details of all earlier failed groups with the same partid, so waitsendpay (and erroronion in listsendpays/listpays) for an earlier group reported the latest group's error. Match on groupid too, like wallet_payment_set_status() and wallet_payment_get_failinfo() already do. Changelog-Fixed: JSON-RPC: `waitsendpay` for an earlier `groupid` now reports that attempt's failure, not the failure of a later retry.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wallet_payment_set_failinfo() matched rows on payment_hash and partid
only, a leftover from before groupid became part of the payments key.
Every failed retry in a new group therefore overwrote the failure
details of all earlier failed groups with the same partid, so
waitsendpay (and erroronion in listsendpays/listpays) for an earlier
group reported the latest group's error.
Match on groupid too, like wallet_payment_set_status() and
wallet_payment_get_failinfo() already do.
Follow up from: #9731 pointed out by @nGoline