Repository navigation
Conversation
Every handler of the LSPS client rebuilt the RPC path from the plugin's configuration and connected to it, eight copies of the same three lines. Keep the RPC path in the client's State, which already gets it at startup, and connect through State::rpc(). Changelog-None
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested in the review of #9716.
Every handler of the LSPS client rebuilt the RPC path from the plugin's configuration and connected to it: eight copies of the same three lines. This keeps the RPC path in the client's
State, which already gets it at startup, and connects throughState::rpc().No behaviour change. Handlers that returned the connection error with
?now carry the "failed to connect to core-lightning" context the hooks already had.#9716 adds two more handlers that connect the same way; whichever of the two PRs merges second moves them over.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade