Repository navigation
fix(jobs): queue follow-up jobs even when the client hangs up - #222
Merged
Merged
Conversation
A deploy approval request queues its Slack notification after the record is saved, using the request's context. If the client disconnected first, the context was cancelled, River's insert failed with "context canceled" and nobody was told about the request, though the record and its audit entry were saved. jobs.Client.InsertAfterWrite keeps the request's values but not its cancellation, with its own 10-second timeout. It queues the job of every write that's already committed: - the Slack notification and the GitHub PR comment for a new deploy approval request - the CircleCI approval job when a request is approved - the welcome and admin emails for a new user - the audit event notification, which already ignored cancellation through its own timeout
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Nov 11, 2026 11:01p.m. | Review ↗ |
| Go | |
Nov 11, 2026 11:01p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deploy approval request queues its Slack notification after the record is saved, using the request's context. If
the client disconnected first, the context was cancelled, River's insert failed with "context canceled" and nobody
was told about the request, though the record and its audit entry were saved.
jobs.Client.InsertAfterWrite keeps the request's values but not its cancellation, with its own 10-second timeout. It
queues the job of every write that's already committed: