Repository navigation
Preserve MSIX manifest content-type overrides during signing - #50
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
…staging MakeAppx emits an xml Default (text/xml) plus an explicit AppxManifest.xml Override. The staged [Content_Types].xml dropped the valid Override, so the Default took effect and signing failed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the portable signing failure in https://github.com/Devolutions/pwsh-distro/actions/runs/43315758239. Staging previously discarded a valid manifest override, causing the manifest to resolve to
text/xml.Validation
cargo test -p psign-sip-digest --locked(196 passed)cargo clippy -p psign-sip-digest --all-targets --locked -- -D warningscargo test -p psign-portable-core staged_and_signed_msix_use_appx_zip64_layout --lockedcargo fmt --allandgit diff --checkNo pwsh-distro packaging change is required; integration needs a published psign version containing this fix.