Repository navigation
Apply the crash limits to crash reports of bulk users - #188
Open
turtledreams wants to merge 3 commits into
Open
turtledreams wants to merge 3 commits into
turtledreams wants to merge 3 commits into
Conversation
report_trace cut trace.app_metrics, while traces carry apm_metrics, so custom metrics were never limited. Custom metrics now keep to the key, value and segmentation limits, and the reserved metrics that the server reads, such as duration and response_time, are sent whole. A trace without metrics is still refused, and a refused bulk trace returns the bulk user for chaining.
report_app_start put the duration under app_metrics, so report_trace refused the trace and nothing was sent. Its start time was also the process uptime instead of a timestamp. It now sends the "app_start" trace from the process start until the call, as the APM guide names it.
report_crash queued the crash report as given. The stack trace now keeps to the stack trace limits per thread, at most 50 threads and 20,000 characters, unless it is a native crash dump. The newest breadcrumbs are kept, each cut to the value limit, and the crash segmentation keeps to the key, value and segmentation limits. The given report is not changed.
CI report
Public API changes: Public API, No public API changeNo public API change. For 019b6d3, updated 2026-11-17 09:56 UTC. Each check's run page has its full log. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #187: the first two commits are the ones from #187, so #187 merges first.
Crash reports of bulk users now keep to the crash limits.
report_crashqueued the report as given, so none of the limits applied._errorkeeps to the stack trace limits of the SDK development guide: threads are separated by blank lines, at most 50 threads ofmax_stack_trace_lines_per_threadlines ofmax_stack_trace_line_lengthcharacters, and at most 20,000 characters in all. A native crash dump (_native_cpp: true) is sent whole, as the guide says. A stack trace within the limits is sent unchanged._logskeeps the newestmax_breadcrumb_countbreadcrumbs, each cut tomax_value_sizecharacters._customkeeps to the key, value and segmentation limits.report_crashis copied, not changed. The stack trace limits are incc.truncateStackTraceso that other callers can share them.Tests in
test/tests_bulk_fixes.jscover the set limits, a native dump next to the same text in a JavaScript crash, and the default limits (threads, lines, total length, breadcrumbs); they fail without the fix.npm testpasses locally (256 tests).