Repository navigation
Let bulk users use the limits set for the bulk instance - #186
Merged
Merged
Conversation
CountlyBulk read its limits from properties that were never set, so the events it queued were never cut. add_user now copies the bulk user's settings as given, since the event limits do not apply to them.
A bulk user took its limits only from its own settings and otherwise used the defaults, so the limits set for CountlyBulk did not reach user details, custom properties, views, conversions and traces. A limit set for the user still takes precedence.
CI report
Public API changes: Public API, No public API changeNo public API change. For 135d896, updated 2026-11-16 08:24 UTC. Each check's run page has its full log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #182: the first commit is the one from #182, so #182 merges first.
A bulk user took its limits only from the settings passed to
add_userand otherwise used the defaults, so themax_*limits set forCountlyBulknever reached the bulk user's own methods: user details, custom properties, views, conversions and traces. A bulk user now falls back to the limits of itsCountlyBulkinstance, and a limit set for the user still takes precedence.CountlyBulknothing changes, since its defaults are the same as the bulk user's.max_*options now name this fallback.Tests in
test/tests_bulk_fixes.js: the profile, custom properties, views and traces of a bulk user keep to the limits set forCountlyBulk(fails without the fix), and a limit set for the user takes precedence.npm testpasses locally (249 tests).