Skip to content

Alarm tree copy+cut+paste - #4029

Open
LordIdra wants to merge 12 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-copy-cut-paste
Open

LordIdra wants to merge 12 commits into
ControlSystemStudio:masterfrom
LordIdra:alarm-tree-copy-cut-paste

Conversation

@LordIdra

@LordIdra LordIdra commented Nov 17, 2026 •

Copy link
Copy Markdown

Part of #3995

Headline change: adds 3 new context menu buttons
image

2026-11-17.16-42-30.mp4

Implementation details

  • Pasting a node prompts you to if a deep copy should be created
  • You can only copy/cut 1 item at a time for now as I wanted to keep this PR small, but can look into this in future
  • The clipboard is stored as a field, separate from your device's clipboard
    • This is mostly to avoid having to serialize/deserialize nodes just to copy/cut/paste when it can be easily held in memory (especially if copying a very deep tree...)
  • If the clipboard is empty, the paste button is disabled
  • If you try to paste an item to a parent which already has an item with the same name, you're prompted to rename it

Other changes

  • Added overload of AlarmClientLeaf#createDetachedCopy to allow passing a new name
  • Added AlarmClientNdode#createDetachedCopy (copied from the alarm tree property editor branch)
  • Added AlarmTreeHelper#moveItem to abstract out some common code and refactored associated methods to call it
  • Refactored DuplicatePVAction to remove code duplication (ironically)
  • Added RenameDialog (used by the new paste action) and refactored RenameTreeItemAction and DuplicatePVAction to use it
  • Refactored RenameTreeItemAction to collapse a lot of duplicate code

(Sorry for the inflated diff because of refactors - figured if I was touching these classes anyway I may as well do some small cleanups)

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes: Manually tested
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@georgweiss

georgweiss commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

@LordIdra, not sure about the copy scenario... Currently PVs can only occur once per alarm configuration. Or is it about copying between different configurations?

@LordIdra

Copy link
Copy Markdown
Author

@LordIdra, not sure about the copy scenario... Currently PVs can only occur once per alarm configuration. Or is it about copying between different configurations?

Yeah that's just a silly oversight on my part, I did not realise that you could only have one instance of a PV per config as I never tried to add a duplicate one. I will just prompt the user for a rename each time and check the whole tree for an existing duplicate PV. Right now you cannot copy/paste between configs but this is definitely a good use case. So I think I'm going to change the implementation to actually use the system clipboard to facilitate this.

@LordIdra LordIdra mentioned this pull request Nov 18, 2026
26 tasks
@LordIdra
LordIdra force-pushed the alarm-tree-copy-cut-paste branch from 538134d to fbf8834 Compare November 19, 2026 10:35
@LordIdra

Copy link
Copy Markdown
Author

Yeah that's just a silly oversight on my part, I did not realise that you could only have one instance of a PV per config as I never tried to add a duplicate one. I will just prompt the user for a rename each time and check the whole tree for an existing duplicate PV. Right now you cannot copy/paste between configs but this is definitely a good use case. So I think I'm going to change the implementation to actually use the system clipboard to facilitate this.

So this is rather more complicated than I thought at first... There is no inbuilt serialization for alarm nodes (and don't want to add it just for this...) so just made the clipboard static to persist it across trees. Not ideal, but I think it should not pose a problem in practice. The problem now is that cut doesn't really work across multiple configs because it requires action across multiple configs which may not be loaded... e.g. if I cut a node in Config A and then navigate to Config B and paste it, Config A is no longer loaded so I cannot delete the item from there. I have solved this by just popping up an error box when the user tried to cut/paste across multiple configs.

I also found and fixed some more issues. Unfortunately it has turned into a bit of a special case hell when pasting. Here is the latest demo:

2026-11-19.10-39-06.1.mp4

Should all be ready now.

@LordIdra
LordIdra marked this pull request as ready for review November 19, 2026 11:10
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants