Repository navigation
Add a line count - #7
Open
github-actions[bot] wants to merge 3 commits into
Open
github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
|
|
||
| def line_count(text): | ||
| """Return how many lines *text* holds.""" | ||
| return len(text.split("\n")) |
Author
There was a problem hiding this comment.
"".split("\n") gives [''], so empty text counts as one line. splitlines() handles that, and Windows line endings too:
Suggested change
| return len(text.split("\n")) | |
| if not text: | |
| return 0 | |
| return len(text.splitlines()) |
|
|
||
| class LineCountTests(unittest.TestCase): | ||
| def test_counts_lines(self): | ||
| self.assertEqual(tally.line_count("one\ntwo"), 2) |
Author
There was a problem hiding this comment.
Could you add a test for empty text as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
line_count(text), with a test.Closes #2.