Skip to content

feat(desktop): build Windows payloads for manual signing - #7

Merged
taylorarndt merged 7 commits into
mainfrom
windows-release
Nov 20, 2026
Merged

taylorarndt merged 7 commits into
mainfrom
windows-release

Conversation

@accesswatch

@accesswatch accesswatch commented Nov 19, 2026 •

Copy link
Copy Markdown

Issue for this PR

Continues the Windows packaging work from #1.

Type of change

  • New feature
  • Bug fix
  • Documentation

What does this PR do?

Windows CI builds unsigned Dev installers and portable editions for x64 and ARM64. A manually triggered workflow on main prepares unsigned stable app and portable folders for both architectures. The release maintainer signs the payloads on Windows, builds and signs the installers, and verifies the results before publishing. The desktop README documents that process.

The app now uses a regular TypeScript declaration file that references the shared UI declarations. It works on checkouts with or without symlink support.

The Linux PR unit tests and API documentation build now run on GitHub-hosted Ubuntu for Access Code. The SDK tests cover the nine config aliases already exposed by the shipped clients. The code generator preserves those aliases, and the OpenAPI document includes the corresponding experimental endpoints.

How did you verify your code works?

  • During development, Jeff built 2.3.2 for both Windows architectures and reported successful Authenticode verification of the two local installers and the binaries in both portable archives, preserving existing Microsoft signatures. Those signed candidates were local artifacts.
  • Taylor’s basic Windows testing seemed functional. She had no providers connected on Windows, which limited coverage of her usual Mac workflows.
  • On commit 5b337fa, a fresh Apple Silicon checkout restored the declaration as a regular file. The app typecheck, root bun run check, formatting, and diff checks passed. The bundled CLI and Mac beta packaged successfully. The packaged Apple Silicon beta opened Home against an isolated service. New session opened the composer, typing enabled Send, and Command-comma opened Settings. The Accessibility tab exposed the announcement controls and both heading-level selectors. Spoken VoiceOver, provider sign-in, and release signing and notarization were outside this smoke test.
  • The full client suite passed locally (262 tests), and regenerating both SDKs and the OpenAPI document reproduced the committed files.
  • Public distribution still needs the manually signed Windows release artifacts and an installed signed upgrade test.

Checklist

  • Tested locally as described above.
  • Changes are scoped to Windows packaging, its documentation, and the declaration checkout fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Hey! Your PR title Add signed Windows release candidates doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@taylorarndt taylorarndt changed the title Add signed Windows release candidates feat(desktop): build Windows payloads for manual signing Nov 20, 2026
@github-actions

Copy link
Copy Markdown

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@taylorarndt

Copy link
Copy Markdown
Member

Jeff, Windows signing is now manual. CI prepares unsigned x64 and ARM64 payloads, and the desktop README covers signing the app, portable files and installers. The declaration is now a regular file and type-checks in a fresh Mac checkout. Both Windows jobs passed and uploaded all four artifacts on the preceding commit. The only subsequent change installs ripgrep in Linux CI.

Taylor’s basic Windows testing seemed functional. She had no providers connected on Windows, so she couldn’t exercise her usual provider-backed Mac workflows there. On Apple Silicon, the packaged beta opened Home, New session accepted typing and enabled Send, and Command-comma opened Settings. The Accessibility tab exposed the announcement controls and both heading selectors. Spoken VoiceOver and a manually signed Windows install and upgrade still need verification.

The client suite passed locally (262 tests) after correcting coverage for nine existing config aliases. SDK and OpenAPI generation checks also passed locally. The remaining known Linux CI issue at merge time is that the previous run failed offline search tests when the runner tried to download ripgrep. The current run installs ripgrep before testing and is still running. Taylor approved merging with this documented.

@taylorarndt
taylorarndt merged commit c538198 into main Nov 20, 2026
10 of 11 checks passed
@taylorarndt

Copy link
Copy Markdown
Member

Jeff, could you share a download link here for the manually signed x64 and ARM64 Windows installers you built, along with the signed portable builds if available? Please include the source commit and version or release channel. That will let us verify the signatures and match the files to the right community beta before attaching them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants