Repository navigation
feat(desktop): build Windows payloads for manual signing - #7
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Jeff, Windows signing is now manual. CI prepares unsigned x64 and ARM64 payloads, and the desktop README covers signing the app, portable files and installers. The declaration is now a regular file and type-checks in a fresh Mac checkout. Both Windows jobs passed and uploaded all four artifacts on the preceding commit. The only subsequent change installs ripgrep in Linux CI. Taylor’s basic Windows testing seemed functional. She had no providers connected on Windows, so she couldn’t exercise her usual provider-backed Mac workflows there. On Apple Silicon, the packaged beta opened Home, New session accepted typing and enabled Send, and Command-comma opened Settings. The Accessibility tab exposed the announcement controls and both heading selectors. Spoken VoiceOver and a manually signed Windows install and upgrade still need verification. The client suite passed locally (262 tests) after correcting coverage for nine existing config aliases. SDK and OpenAPI generation checks also passed locally. The remaining known Linux CI issue at merge time is that the previous run failed offline search tests when the runner tried to download ripgrep. The current run installs ripgrep before testing and is still running. Taylor approved merging with this documented. |
|
Jeff, could you share a download link here for the manually signed x64 and ARM64 Windows installers you built, along with the signed portable builds if available? Please include the source commit and version or release channel. That will let us verify the signatures and match the files to the right community beta before attaching them. Thanks! |
Issue for this PR
Continues the Windows packaging work from #1.
Type of change
What does this PR do?
Windows CI builds unsigned Dev installers and portable editions for x64 and ARM64. A manually triggered workflow on main prepares unsigned stable app and portable folders for both architectures. The release maintainer signs the payloads on Windows, builds and signs the installers, and verifies the results before publishing. The desktop README documents that process.
The app now uses a regular TypeScript declaration file that references the shared UI declarations. It works on checkouts with or without symlink support.
The Linux PR unit tests and API documentation build now run on GitHub-hosted Ubuntu for Access Code. The SDK tests cover the nine config aliases already exposed by the shipped clients. The code generator preserves those aliases, and the OpenAPI document includes the corresponding experimental endpoints.
How did you verify your code works?
bun run check, formatting, and diff checks passed. The bundled CLI and Mac beta packaged successfully. The packaged Apple Silicon beta opened Home against an isolated service. New session opened the composer, typing enabled Send, and Command-comma opened Settings. The Accessibility tab exposed the announcement controls and both heading-level selectors. Spoken VoiceOver, provider sign-in, and release signing and notarization were outside this smoke test.Checklist