Repository navigation
London | 26-Sep-ITP | Frumentius Tesfay | Sprint 3 | Coursework/sprint 3 dead code - #1772
Open
Frumentius-Rev wants to merge 7 commits into
Open
Frumentius-Rev wants to merge 7 commits into
Frumentius-Rev wants to merge 7 commits into
Conversation
Frumentius-Rev
added
the
Needs Review
|
Thank you for this PR. Great job cleaning up the dead code in Exercises 1 and 2. Just one tiny optional cleanup in dead-code/exercise-1.js: testName is initialized to "Jerry" before immediately being reassigned to "Aman", so you can remove the "Jerry" initialization (e.g., just declare const testName = "Aman";). Otherwise, looks great and ready to go for approval. |
Author
|
Thank you for your clear feedback. I have removed it as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Removed redundant, unused, and unreachable code from Exercises 1 and 2 while preserving the existing functionality.