Repository navigation
Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 2 | Implement-and-rewrite-tests - #1732
Monsur0001 wants to merge 12 commits into
Conversation
…getCardValue function
Monsur0001
added
📅 Sprint 2
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Could you use a formatter to keep the code consistently format?
-
Code looks good. Well done.
-
You missed implement the Jest tests in
rewrite-tests-with-jest.
| test("Classifies reflex angles", () => { | ||
| const reflex = getAngleType(270); | ||
| assert.equal(reflex, "Reflex angle"); | ||
| }); | ||
|
|
||
| test("Handles invalid angles (negative)", () => { | ||
| const invalidNegative = getAngleType(-30); | ||
| assert.equal(invalidNegative, "Invalid angle"); | ||
| }); No newline at end of file |
There was a problem hiding this comment.
Why not test the boundary cases?
Also, you could consider testing multiple values, including boundary cases, within each category.
There was a problem hiding this comment.
Thank you for taking time to review my code, I have added boundary cases to each of the test cases, right, acute, obtuse etc.
There was a problem hiding this comment.
-
In your changes, you included more samples, but the test still does not include the boundary cases for invalid angles. Could you use AI to explore what kind of values are considered boundary cases when testing a function?
-
You missed implement the three Jest tests in the
rewrite-tests-with-jestfolder.
cjyuan
added
Reviewed
Monsur0001
added
the
Needs Review
cjyuan
removed
the
Needs Review
Self checklist
Task code
CYF-1059
Changelist
Implemented and rewrote test cases