[shirinpanahian]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1083

Changelist

This PR includes my work for Sprint 2 of the Module Data Groups project.

• Debug: Analysed the existing code, predicted and explained the bugs, ran the files using Node.js, and fixed the issues.
• Implement: Worked on implementing functions based on the provided requirements, including contains, lookup, tally, and querystring. Tested the functions with different inputs to verify their behaviour.
• Interpret: Worked through the provided programs to understand unfamiliar JavaScript syntax, operators, and functions using documentation and console.log().

This sprint helped me improve my JavaScript problem-solving, debugging, implementation, and code-reading skills.

[valentina-starr1]

Thank you for this PR. Great work completing the Sprint 2 exercises and adding tests.

I can see two small JavaScript edge cases to fix before merging:

tally.js (line 12): Plain objects inherit built-in keys like toString, so tally(["toString"]) tries to add 1 to a function instead of returning { toString: 1 }. Using Object.hasOwn() or Object.create(null) fixes this.

querystring.js (line 38): Assigning "proto" directly to a normal object changes its prototype instead of saving it as a key. Using Object.create(null) or Object.defineProperty() handles it safely.

[shirinpanahian]

Thank you for the feedback and the helpful explanations!

I've fixed both edge cases using Object.hasOwn() in tally.js and Object.create(null) in querystring.js.

I've also added tests to cover these cases and pushed the updates to the PR.

Thanks again for the review!

Thank you for this PR. Great work completing the Sprint 2 exercises and adding tests.

I can see two small JavaScript edge cases to fix before merging:

tally.js (line 12): Plain objects inherit built-in keys like toString, so tally(["toString"]) tries to add 1 to a function instead of returning { toString: 1 }. Using Object.hasOwn() or Object.create(null) fixes this.

querystring.js (line 38): Assigning "proto" directly to a normal object changes its prototype instead of saving it as a key. Using Object.create(null) or Object.defineProperty() handles it safely.