Skip to content

Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint 2 | Coursework/sprint 2 - #1514

Open
AkliluMihtsun wants to merge 22 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/Sprint-2
Open

Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint 2 | Coursework/sprint 2#1514
AkliluMihtsun wants to merge 22 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/Sprint-2

Conversation

@AkliluMihtsun

@AkliluMihtsun AkliluMihtsun commented Nov 11, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

I have completed the coursework/Sprint-2

@AkliluMihtsun
Fix address object property access to log house number correctly
caa5bb0
@AkliluMihtsun
Fix for loop to correctly iterate over object properties in author.js
e2397d8
@AkliluMihtsun
Fix recipe.js to correctly log ingredients and improve comments
df238c9
@AkliluMihtsun
Add tests for contains function to validate object property checks an…
345b355 
…d error handling
@AkliluMihtsun
Implement contains function to check for property existence in an object
2ae7312
@AkliluMihtsun
Add jsconfig.json and update package.json for Jest type definitions
fd4f6f5
@AkliluMihtsun
Remove unnecessary TypeScript reference from contains.test.js
a5c908d
@AkliluMihtsun
Refactor tests in lookup.test.js to validate createLookup function be…
3a2f213 
…havior and error handling
@AkliluMihtsun
Implement createLookup function to transform country-currency pairs i…
4563f09 
…nto an object
@AkliluMihtsun
Implement tally function to count occurrences of items in an array
64405b5
@AkliluMihtsun
Refactor tally tests to improve clarity and coverage
c4e3c36
@AkliluMihtsun
Refactor parseQueryString function to improve query parameter handlin…
6a4db13 
…g and readability
@AkliluMihtsun
Fix syntax error in querystring.test.js by adding missing semicolon
7aae036
@AkliluMihtsun
Fix invert function implementation to correctly swap keys and values …
dc40ffc 
…in the object
@AkliluMihtsun
Add tests for invert function to verify key-value inversion
2ebc9d0
@github-actions

This comment has been minimized.

Sign in to view
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026
@AkliluMihtsun AkliluMihtsun changed the title Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint-2 | Coursework/sprint 2 Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint 2 | Coursework/sprint 2 Nov 11, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026
@tee4tao tee4tao added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2026
tee4tao
tee4tao suggested changes Nov 12, 2026
View reviewed changes
Comment thread Sprint-2/debug/author.js Resolved
Comment thread Sprint-2/debug/author.js Resolved
Comment thread Sprint-2/implement/contains.js Resolved
Comment thread Sprint-2/implement/contains.js Resolved
Comment thread Sprint-2/debug/recipe.js Resolved
Comment thread Sprint-2/debug/recipe.js Resolved
Comment thread Sprint-2/implement/lookup.js Resolved
Comment thread Sprint-2/implement/tally.js Resolved
Comment thread Sprint-2/implement/tally.test.js Resolved
Comment thread Sprint-2/implement/tally.test.js Resolved
@tee4tao tee4tao added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 12, 2026
@tee4tao tee4tao added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tee4tao tee4tao tee4tao requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AkliluMihtsun @tee4tao