Repository navigation
Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 2 | Analyse Refactor Functions - #239
Open
shreefAhmedM wants to merge 5 commits into
Open
shreefAhmedM wants to merge 5 commits into
shreefAhmedM wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
shreefAhmedM
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shreefAhmedM
changed the title
shreefAhmedM
added
the
Needs Review
illicitonion
left a comment
illicitonion
left a comment
Member
There was a problem hiding this comment.
This generally looks good, but has a lot of lack of attention to detail - please take a look and fix up the comments
Member
There was a problem hiding this comment.
You haven't explained the complexity of the before or after code
illicitonion
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
shreefAhmedM
changed the title
This comment has been minimized.
This comment has been minimized.
shreefAhmedM
added
the
Needs Review
cjyuan
reviewed
Nov 10, 2026
| return uniqueValues; | ||
| }; | ||
|
|
||
| console.log(findCommonItems([2, 5, 7], [5, 6, 7])); |
There was a problem hiding this comment.
Code submitted to a PR should be free of debugging code.
Comment on lines
+13
to
+17
| const allowedItems = new Set(secondArray); | ||
|
|
||
| const uniqueValues = [ | ||
| ...new Set(firstArray.filter((item) => allowedItems.has(item))), | ||
| ]; |
There was a problem hiding this comment.
Note:
Most Set implementations (regardless of languages) support the common set operations such as union, intersection, difference, subset, superset, equality, add, remove, contains, size, clear, and is empty.
You could consider taking advantage of them for optimal performance.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1173
Changelist
This PR analyses and refactors functions to improve efficiency, reduce time complexity, and follow best practices. It documents the original and optimised time and space complexities for each function.