Repository navigation
Tests: the two quoted-parallel import tests assert OK on every engine, the 26.12.1 refusal is fixed upstream - #378
Merged
Conversation
…, the 26.12.1 refusal is fixed upstream (closes #376) ArcadeData/arcadedb#11441 fixed ArcadeData/arcadedb#11367 (merge 4dc44565cf, 2026-11-11 19:30 UTC): IMPORT DATABASE accepts a backtick-quoted setting name again, so the 26.12.1-SNAPSHOT engine answers OK for `parallel` = 1, as 26.11.1 does. The two tests still expected the refusal from 26.12.1 on and failed on every leg of test-jvm.yml of every pull request. The version gate (QUOTED_PARALLEL_REFUSED_SINCE, _quoted_parallel_refused and _engine_version, used by nothing else in the file) goes, and both tests assert OK and the record counts on every engine, as the comment above the gate said they would once #11367 was fixed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the version gate of the two quoted-
paralleltests intests/test_import_database.py(QUOTED_PARALLEL_REFUSED_SINCE,_quoted_parallel_refused, and_engine_version, which nothing else in the file used). Both tests now assertOKand the record counts on every engine. ArcadeData/arcadedb#11441 fixed ArcadeData/arcadedb#11367 on 2026-11-11 19:30 UTC, so the 26.12.1-SNAPSHOT engine accepts the quoted name again, as 26.11.1 does. The gate expected the refusal from 26.12.1 on, and the tests failed on every leg oftest-jvm.ymlof every pull request since.Related issues
Closes #376
Docs
None needs it.
examples/15_*andexamples/16_*still skip the quotedparallelon a 26.12.1 engine and say it is refused; they pass, so I left them out of this blocker fix.Checklist
assert 'OK' == 'FAIL'); the old gate expected the refusal, the new code assertsOK. CI runs them on the snapshot engine.uvx pre-commit run --files tests/test_import_database.pypasses.🤖 Generated with Claude Code