Skip to content

[PWGCF] JCorran/Tasks: Added custom centrality binning for SPC analysis - #18784

Merged
jaelpark merged 2 commits into
AliceO2Group:masterfrom
nmallick19:master
Nov 17, 2026
Merged

jaelpark merged 2 commits into
AliceO2Group:masterfrom
nmallick19:master

Conversation

@nmallick19

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 4 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c43c2a8 at 2026-11-17 08:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 11 warnings.'
Found 2 errors and 11 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/5d0726e24c9fd2777a53adaec805ba704c7660dc/O2Physics-code-check/errors.txt
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:69:3: error: no header providing "o2::framework::OutputObj" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:146:17: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/5d0726e24c9fd2777a53adaec805ba704c7660dc/O2Physics-code-check/warnings.txt
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:57:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:66:8: warning: constructor does not initialize these fields: multCutFormulaParamIndex [cppcoreguidelines-pro-type-member-init]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:168:32: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:201:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:229:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:231:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:246:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:257:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:260:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:294:132: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/flowJSPCAnalysis.cxx:296:33: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@jaelpark
jaelpark merged commit e53b7cf into AliceO2Group:master Nov 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants