Skip to content

[PWGCF] Calculation of azimuthal correlations using GFW added - #18781

Merged
wenyaCern merged 7 commits into
AliceO2Group:masterfrom
vojmach:master
Nov 17, 2026
Merged

wenyaCern merged 7 commits into
AliceO2Group:masterfrom
vojmach:master

Conversation

@vojmach

@vojmach vojmach commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e255542 at 2026-11-16 23:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 3 warnings.'
Found 8 errors and 3 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/d2ee6450bfc732ad5ace29923da53464997ad742/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTransmutation.cxx:149:92: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:564:28: error: no header providing "TNamed" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:748:51: error: no header providing "kTRUE" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:752:51: error: no header providing "kFALSE" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:822:58: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:822:113: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:886:32: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTransmutation.cxx:886:87: error: redundant explicit casting to the same type 'TH1D *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d2ee6450bfc732ad5ace29923da53464997ad742/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTransmutation.cxx:525:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTransmutation.cxx:910:29: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGCF/Flow/Tasks/flowTransmutation.cxx:910:45: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

@vojmach
vojmach marked this pull request as draft November 16, 2026 22:02
@vojmach
vojmach marked this pull request as ready for review November 16, 2026 22:34
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 19a5b19 at 2026-11-16 23:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:50:2: error: invalid preprocessing directive #inlcude; did you mean #include?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:824:91: error: no matching function for call to 'TH1D::GetBinContent(TH1D*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 19a5b19 at 2026-11-16 23:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:50:2: error: invalid preprocessing directive #inlcude; did you mean #include?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:824:91: error: no matching function for call to 'TH1D::GetBinContent(TH1D*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 19a5b19 at 2026-11-16 23:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:50:2: error: invalid preprocessing directive #inlcude; did you mean #include?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTransmutation.cxx:824:91: error: no matching function for call to 'TH1D::GetBinContent(TH1D*&)'
ninja: build stopped: subcommand failed.

Full log here.

@vojmach
vojmach marked this pull request as draft November 17, 2026 05:37
@vojmach
vojmach marked this pull request as ready for review November 17, 2026 07:18
@vojmach
vojmach marked this pull request as draft November 17, 2026 08:49
@vojmach
vojmach marked this pull request as ready for review November 17, 2026 09:02
@wenyaCern
wenyaCern merged commit eccf82e into AliceO2Group:master Nov 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants