Skip to content

[PWGHF] Add DCAFitter ML input features for Omegac0 - #18761

Merged
fcatalan92 merged 2 commits into
AliceO2Group:masterfrom
mtorresc15:omegac-dcafitter-ml-features
Nov 16, 2026
Merged

fcatalan92 merged 2 commits into
AliceO2Group:masterfrom
mtorresc15:omegac-dcafitter-ml-features

Conversation

@mtorresc15

Copy link
Copy Markdown
Contributor

This PR adds the normalized impact parameters and the three dimensional decay length of the Omegac0 candidate as input features for the DCAFitter ML selection.

  • Add normImpParCascade and normImpParPiFromCharmBar as dynamic columns in CandidateReconstructionTables.h.

  • Register normImpParCascade, normImpParPiFromCharmBar, and decLenCharmBaryon as DCAFitter ML input features in HfMlResponseOmegacToOmegaPiQa.h.

  • Update treeCreatorOmegac0ToOmegaPiQa.cxx to use the new dynamic-column accessors.

@github-actions github-actions Bot changed the title Add DCAFitter ML input features for Omegac0 [PWGHF] Add DCAFitter ML input features for Omegac0 Nov 15, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 3 disabled

@fcatalan92 fcatalan92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtorresc15, the changes look good to me. I would just specify in the name of the columns that this is the impact parameter in the XY plane.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fb2ee87 at 2026-11-16 11:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 3 warnings.'
Found 4 errors and 3 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/81026ab02cec542f6664bd5643af2269dd6e8818/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:26:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:27:1: error: included header string is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:28:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/81026ab02cec542f6664bd5643af2269dd6e8818/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:41:9: warning: function-like macro 'CHECK_AND_FILL_VEC_OMEGAC0_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:43:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:49:9: warning: function-like macro 'CHECK_AND_FILL_VEC_OMEGAC0' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@fcatalan92
fcatalan92 enabled auto-merge (squash) November 16, 2026 15:31
@fcatalan92
fcatalan92 merged commit d40060d into AliceO2Group:master Nov 16, 2026
14 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 94e3116 at 2026-11-16 17:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 3 warnings.'
Found 4 errors and 3 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/306f5420f1db721e1171833cf55fe7ec9d136628/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:26:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:27:1: error: included header string is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:28:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/306f5420f1db721e1171833cf55fe7ec9d136628/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:41:9: warning: function-like macro 'CHECK_AND_FILL_VEC_OMEGAC0_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:43:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h:49:9: warning: function-like macro 'CHECK_AND_FILL_VEC_OMEGAC0' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants