Skip to content

[Common] improvements to the muon QA task - #18024

Open
aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:Common-muon-qa-improve-event-selection
Open

aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:Common-muon-qa-improve-event-selection

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor
  • added configurable event selection options
  • added option for adjusting the bias for the magnetic field longitudinal position

- added configurable event selection options
- added option for adjusting the bias for the magnetic field
  longitudinal position
@aferrero2707
aferrero2707 marked this pull request as draft September 23, 2026 10:07
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 181 warnings, 🔕 0 disabled

@ktf

ktf commented Oct 12, 2026

Copy link
Copy Markdown
Member

@aferrero2707 any reason this is still draft?

@aferrero2707

Copy link
Copy Markdown
Contributor Author

@aferrero2707 any reason this is still draft?

@ktf I wanted to have a closer look at the MegaLinter errors but had no time so far... will try to finalize the PR this week.

@github-actions

Copy link
Copy Markdown

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions Bot added the stale label Nov 13, 2026
@aferrero2707
aferrero2707 marked this pull request as ready for review November 14, 2026 20:54
@aferrero2707

Copy link
Copy Markdown
Contributor Author

I propose to address the MgaLinter errors in a separate PR, as there are quite some fixes needed by the seem not too serious.

@alibuild

alibuild commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b3e1313 at 2026-11-19 04:27:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 31 warnings.'
Found 5 errors and 31 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/2aa539eea3bfec5742acfe2518057d6b3cd10128/O2Physics-code-check/errors.txt
Common/Tasks/qaMuon.cxx:559:109: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
Common/Tasks/qaMuon.cxx:568:98: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
Common/Tasks/qaMuon.cxx:585:109: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
Common/Tasks/qaMuon.cxx:591:98: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
Common/Tasks/qaMuon.cxx:2430:15: error: no header providing "o2::conf::ConfigurableParam" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 31 -gt 0 ]]
++ cat /sw/BUILD/2aa539eea3bfec5742acfe2518057d6b3cd10128/O2Physics-code-check/warnings.txt
Common/Tasks/qaMuon.cxx:79:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
Common/Tasks/qaMuon.cxx:99:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tasks/qaMuon.cxx:100:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tasks/qaMuon.cxx:106:23: warning: variable 'zRefPlane' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
Common/Tasks/qaMuon.cxx:114:45: warning: variable 'referencePlanes' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
Common/Tasks/qaMuon.cxx:180:8: warning: constructor does not initialize these fields: fCurrentRun, mImproveCutChi2, ccdb, Bz [cppcoreguidelines-pro-type-member-init]
Common/Tasks/qaMuon.cxx:1151:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
Common/Tasks/qaMuon.cxx:1168:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
Common/Tasks/qaMuon.cxx:1252:9: warning: do not use 'else' after 'break' [readability-else-after-return]
Common/Tasks/qaMuon.cxx:1292:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
Common/Tasks/qaMuon.cxx:1307:48: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1326:41: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1485:49: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1491:41: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1503:53: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1532:49: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1538:41: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1555:53: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:1648:7: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Common/Tasks/qaMuon.cxx:2379:9: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tasks/qaMuon.cxx:2380:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
Common/Tasks/qaMuon.cxx:2596:68: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
Common/Tasks/qaMuon.cxx:2678:75: warning: narrowing conversion from 'value_type' (aka 'float') to 'int' [bugprone-narrowing-conversions]
Common/Tasks/qaMuon.cxx:3007:32: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:3044:14: warning: variable 'dcaXPair' is not initialized [cppcoreguidelines-init-variables]
Common/Tasks/qaMuon.cxx:3045:14: warning: variable 'dcaYPair' is not initialized [cppcoreguidelines-init-variables]
Common/Tasks/qaMuon.cxx:3509:34: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:3514:36: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/qaMuon.cxx:3516:13: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@github-actions github-actions Bot removed the stale label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants