Repository navigation
Conversation
Since 26.1, World#getWorldFolder() returns the dimension folder, so the datapack was saved into world/dimensions/minecraft/<dimension>/datapacks, where the server never loads it. Use Server#getLevelDirectory() when it exists and fall back to the main world's folder on older versions. Fixes APDevTeam#776 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
initializeDatapack() calls setEnabled(false) when the datapack cannot be loaded, but onEnable() kept going and scheduled tasks on the disabled plugin, causing an IllegalPluginAccessException. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
Since 26.1,
World#getWorldFolder()returns the dimension folder, soinitializeDatapack()savedmovecraft-data.zipintoworld/dimensions/minecraft/the_end/datapacks, where the server never loads it. This usesServer#getLevelDirectory()(26.1+) through reflection, since the shared code compiles against 1.20.6, and falls back to the main world's folder on older versions.It also stops
onEnable()afterinitializeDatapack()disables the plugin, which caused theIllegalPluginAccessException.Servers that already hit the bug recover on the next start: a new pack is written to
world/datapacksand enabled.Tested on Paper 26.2 build 135 (fresh world and an already-affected world) and Paper 1.21.11 build 132 (fresh world): the pack is enabled on first start, and all craft types load on first start and on restart.
Related issues:
Checklist