Repository navigation
Conversation
PdfSplitHandle still preferred UploadedFile.chunks() and only fell back to copyfileobj. Routing through get_buffer matches Doc/HTML/XLSX and keeps ZipExtFile members (issue 1Panel-dev#7436) on the same cached-buffer path used by ZipSplitHandle. Fixes 1Panel-dev#7436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7436.
PDF-only zip uploads previously produced an empty split list.
PdfSplitHandlehistorically calledUploadedFile.chunks(), whichZipExtFiledoes not provide;ZipSplitHandlethen swallowed the error.On current
v2there is already anhasattr(file, \"chunks\")/shutil.copyfileobjfallback. This PR goes one step further and always writes the temp file fromget_buffer(file), matching Doc/HTML/XLSX handlers and theFileBufferHandlecache thatZipSplitHandlealready builds for each member.Test plan
get_bufferwrite pathapps/common/handle/impl/text/tests/test_pdf_zip_buffer.py(ZipExtFile-like object withoutchunks(); mocksPdfReader/ TOC)AI disclosure
This pull request was prepared with assistance from an autonomous coding agent (Grok Bot). I reviewed the diff and take responsibility for the change.
Note: #7694 was opened against
mainby mistake and closed; this PR targetsv2.