Repository navigation
Conversation
Parallel document embedding for one knowledge base can all pass the pg_indexes existence check and then race on CREATE INDEX, raising DuplicateTable. Use CREATE INDEX IF NOT EXISTS so losers of the race do not fail the embedding task (Fixes 1Panel-dev#7596). Signed-off-by: Vincent <1729065730@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7596.
create_knowledge_index()checkspg_indexesthen runsCREATE INDEX. When a knowledge-base embedding fans out per-document workers, several tasks can pass the check at once; the first create wins and the rest raiseDuplicateTable, failing those document jobs.Change:
CREATE INDEX IF NOT EXISTS ...so a concurrent creator is a no-op.Test plan
IF NOT EXISTS(matches the GIN index pattern already used inapps/knowledge/migrations/0008_termbase.py).AI disclosure
AI-assisted (authored and verified by ump45nose).