Repository navigation
Conversation
Concurrent mcp_response_generator runs that shared /tmp/<chat_id> could delete the directory when the first finished, so later shell execute calls failed with FileNotFoundError on the cwd (1Panel-dev#7625). Always append a uuid to the temp path, and recreate the sandbox cwd before execute as a safety net.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7625: agent shell tools used
/tmp/<chat_id>as the run workspace and deleted it when the generator finished. Concurrent runs (workflow AI nodes / duplicate requests on the same chat) could therefore remove the cwd out from under a sibling still executing commands, producing:FileNotFoundError: [Errno 2] No such file or directory: '/tmp/<chat_id>'Changes
/tmp/<chat_id>-<uuid7>or/tmp/<uuid7>).SandboxShellBackendcwd withos.makedirs(..., exist_ok=True)beforeexecute.Test plan
PYTHONPATH=apps python3 -m unittest application.flow.test_agent_temp_dir -vexecuteno longer loses its cwd mid-turn.AI disclosure
This change was prepared with AI assistance. I reviewed the diff and ran the listed unit tests locally.