Improved pull request "Files Changed" experience feedback #163932
Replies: 3297 comments 1372 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
Bug: triple-clicking a line scrolls the page back to the top (new Files changed experience) What happens Steps to reproduce
Expected Actual Workaround Environment
|
|
I really only have the two following requests
|
|
Bad UX: submitting a PR-level comment from the
Observed: I land on I use that box mid-review, for thoughts that don't belong to a specific line. If the side panel exists so a review can happen on one page, posting from it shouldn't move me to another one. Comment drafted & iterated on with AI assistance |
|
I wanted to leave a review comment on a folder, and there's no way to do it 🤔 Line and file comments are the wrong scope for me, and a PR-level comment isn't a review comment (cannot be resolved). As a workaround I comment on the first file of the directory instead, but if that file is expected to move, be renamed, or deleted, the comment is easily lost 😬.
👉 What I'd be after is a folder-level comment behaving like a file-level one: resolvable, attached to the review, listed with the others. 👉 Same missing gap one level up: I'd like to be able to post comments attached to the review but not a specific file/folder, that I can resolve later. Comment drafted & iterated on with AI assistance |
|
The side panel UI provides no way to unresolve a comment thread. Also when I copy a link to one (which is also outdated, that might batter), navigating to that link doesn't work. Edit: Oh, I see now, I need to Ignore where is says "resolved", and not look in any of the normal places GitHub UI puts options like that (buttons with descriptive text at the bottom of the thread), and click the little purple checkmark that's in the heading of the code excerpt that the commit thread is inside of. I think that UI design choice is unintuitive, though compact. |
|
A few comments here ask for ways to cut a big PR down, like marking whole folders of generated files as viewed. Until something like that ships natively, I built a small open-source Chrome extension that adds it on top of the new Files changed page. Files marked Disclosure: I'm the developer; MIT, no token or account, collects no data: https://github.com/n8v-guy/diffseek |
|
For anyone who wants to try it, it's on the Chrome Web Store: https://chromewebstore.google.com/detail/lpohfkpkmaakdllgpognpjegifccnfec |
|
Some Characters were displaying correctly in the classic experience but in this one they show as diamond question marks. Not sure if it is a ASCII vs UTF-8 issues. I cannot show code due to privacy as it is a private repo. The files in the repo are Windows 1252 encoded containing UTF-8 chars. The old experience shows them correctly. This one does not. |
|
I really love the new sidebar experience—thank you so much for your work! One minor suggestion: the sidebar should be independently scrollable. Currently, its scrolling seems to depend on the main content, so I can’t scroll up (to see the search bar) in the sidebar without first scrolling up the main content. |
|
Highlight the currently displayed file in the file tree |
|
I would love to see a return of the UI buttons for browsing from one commit to the next. With the new UI it's awkward to understand a simple way to view one commit and then go to the next commit. According to this comment, you can browse between commits using keyboard shortcuts. This is great and should be kept, but it's not very discoverable to learn about how to navigate between commits this way. |
|





















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions