Add tests for check order dependence

These tests record checker results that depend on the order in which
files, declarations, and queries are checked, so that each later fix
shows up as a reviewable baseline change. Most list several
checkOrder variants; where the variants disagree, that disagreement is
the bug. Some existing tests also gain the typesfirst order, as asking
for types and symbols first changes what they report.

The cases cover:

- variance measured through cycles of recursive references, which
  depended on which type in the cycle was measured first (64891, and
  a reduction of the react-relay DefinitelyTyped tests);
- circularities whose blamed location is whichever use resolved
  first: circular type parameter defaults and constraints, a cycle
  through namespace spreads, awaiting a promise that refers back to
  itself, and import elision computing types before checking;
- instantiation limit and excessive depth errors, reported only in
  whichever file reached the limit first;
- late-bound members, computed enum members, and aliased
  module.exports members, which differ when queried before checking;
- relation results cached against truncated or in-progress
  comparisons;
- the order of types in unions, which followed type ids, and so
  creation order, for object literals, rest types, indexed accesses,
  type parameters, and iterator method types;
- return type cycles through callbacks and subtype reduction, JSDoc
  type tags on contextually typed functions, a scope whose thunks refer
  to the scope, a never narrowing after a loop, and a const assertion
  inferred before its binding pattern (seen in OmniRoute, effect,
  webpack, arktype, uglify-js, and check order fuzzing).

The circularity tests from PR 64834 are copied unchanged, to compare
against how that PR handles the same cases.

Author: jakebailey

tsc/internal/testrunner/compiler_runner.go

@@ -167,8 +167,21 @@ func (r *CompilerBaselineRunner) runTest(t *testing.T, filename string) {
 	}
 }
 
+// When a program checks its files on several checkers, these tests can see different results depending on which
+// checker answers a query first.
+var concurrentSkippedTests = map[string]string{
+	"checkOrderCircularDefaults.ts":          "Circular default results depend on which checker resolves the cycle first.",
+	"checkOrderSpreadCycle.ts":               "Spread cycle results depend on which checker resolves the cycle first.",
+	"checkOrderStableInstantiationErrors.ts": "Instantiation limit errors depend on which checker instantiates first.",
+}
+
 func (r *CompilerBaselineRunner) runSingleConfigTest(t *testing.T, testName string, test *compilerFileBasedTest, config *harnessutil.NamedTestConfiguration) {
 	t.Parallel()
+	if !testutil.TestProgramIsSingleThreaded() {
+		if msg, ok := concurrentSkippedTests[tspath.GetBaseFileName(test.filename)]; ok {
+			t.Skipf("Skipping in concurrent mode: %s", msg)
+		}
+	}
 	defer testutil.RecoverAndFail(t, "Panic on compiler test "+test.filename)
 
 	payload := makeUnitsFromTest(test.content, test.filename)

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=default).errors.txt

@@ -0,0 +1,69 @@
+badExport.ts(1,10): error TS2304: Cannot find name 'foo'.
+badExport.ts(1,17): error TS1003: Identifier expected.
+badExport.ts(1,20): error TS1128: Declaration or statement expected.
+badExport2.ts(1,10): error TS1003: Identifier expected.
+badExport2.ts(1,16): error TS2304: Cannot find name 'foo'.
+badExport2.ts(1,20): error TS1128: Declaration or statement expected.
+badImport.ts(1,10): error TS1003: Identifier expected.
+badImport.ts(1,10): error TS1141: String literal expected.
+badImport.ts(1,20): error TS1128: Declaration or statement expected.
+badImport.ts(1,22): error TS1434: Unexpected keyword or identifier.
+badImport.ts(1,22): error TS2304: Cannot find name 'from'.
+badImport2.ts(1,17): error TS1003: Identifier expected.
+badImport2.ts(1,17): error TS1141: String literal expected.
+badImport2.ts(1,20): error TS1128: Declaration or statement expected.
+badImport2.ts(1,22): error TS1434: Unexpected keyword or identifier.
+badImport2.ts(1,22): error TS2304: Cannot find name 'from'.
+
+
+==== foo.ts (0 errors) ====
+    const foo = 0n;
+    export { foo as "0n" };
+    
+==== correctUse.ts (0 errors) ====
+    import { "0n" as foo } from "./foo";
+    export { foo as "0n" };
+    
+==== badImport.ts (5 errors) ====
+    import { 0n as foo } from "./foo";
+             ~~
+!!! error TS1003: Identifier expected.
+             ~~~~~~~~~
+!!! error TS1141: String literal expected.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+                         ~~~~
+!!! error TS1434: Unexpected keyword or identifier.
+                         ~~~~
+!!! error TS2304: Cannot find name 'from'.
+    
+==== badImport2.ts (5 errors) ====
+    import { foo as 0n } from "./foo";
+                    ~~
+!!! error TS1003: Identifier expected.
+                    ~~
+!!! error TS1141: String literal expected.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+                         ~~~~
+!!! error TS1434: Unexpected keyword or identifier.
+                         ~~~~
+!!! error TS2304: Cannot find name 'from'.
+    
+==== badExport.ts (3 errors) ====
+    export { foo as 0n };
+             ~~~
+!!! error TS2304: Cannot find name 'foo'.
+                    ~~
+!!! error TS1003: Identifier expected.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+    
+==== badExport2.ts (3 errors) ====
+    export { 0n as foo };
+             ~~
+!!! error TS1003: Identifier expected.
+                   ~~~
+!!! error TS2304: Cannot find name 'foo'.
+                       ~
+!!! error TS1128: Declaration or statement expected.

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=default).js

@@ -0,0 +1,44 @@
+//// [tests/cases/compiler/bigintArbirtraryIdentifier.ts] ////
+
+//// [foo.ts]
+const foo = 0n;
+export { foo as "0n" };
+
+//// [correctUse.ts]
+import { "0n" as foo } from "./foo";
+export { foo as "0n" };
+
+//// [badImport.ts]
+import { 0n as foo } from "./foo";
+
+//// [badImport2.ts]
+import { foo as 0n } from "./foo";
+
+//// [badExport.ts]
+export { foo as 0n };
+
+//// [badExport2.ts]
+export { 0n as foo };
+
+//// [foo.js]
+const foo = 0n;
+export { foo as "0n" };
+//// [correctUse.js]
+import { "0n" as foo } from "./foo";
+export { foo as "0n" };
+//// [badImport.js]
+from;
+"./foo";
+export {};
+//// [badImport2.js]
+from;
+"./foo";
+export {};
+//// [badExport.js]
+export { foo as  };
+0n;
+;
+//// [badExport2.js]
+0n;
+;
+export {};

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=default).symbols

@@ -0,0 +1,34 @@
+//// [tests/cases/compiler/bigintArbirtraryIdentifier.ts] ////
+
+=== foo.ts ===
+const foo = 0n;
+>foo : Symbol(foo, Decl(foo.ts, 0, 5))
+
+export { foo as "0n" };
+>foo : Symbol(foo, Decl(foo.ts, 0, 5))
+>"0n" : Symbol("0n", Decl(foo.ts, 1, 8))
+
+=== correctUse.ts ===
+import { "0n" as foo } from "./foo";
+>foo : Symbol(foo, Decl(correctUse.ts, 0, 8))
+
+export { foo as "0n" };
+>foo : Symbol(foo, Decl(correctUse.ts, 0, 8))
+>"0n" : Symbol("0n", Decl(correctUse.ts, 1, 8))
+
+=== badImport.ts ===
+import { 0n as foo } from "./foo";
+>foo : Symbol(foo)
+
+=== badImport2.ts ===
+import { foo as 0n } from "./foo";
+> : Symbol((Missing), Decl(badImport2.ts, 0, 8))
+
+=== badExport.ts ===
+export { foo as 0n };
+> : Symbol((Missing), Decl(badExport.ts, 0, 8))
+
+=== badExport2.ts ===
+export { 0n as foo };
+>foo : Symbol(foo)
+

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=default).types

@@ -0,0 +1,44 @@
+//// [tests/cases/compiler/bigintArbirtraryIdentifier.ts] ////
+
+=== foo.ts ===
+const foo = 0n;
+>foo : 0n
+>0n : 0n
+
+export { foo as "0n" };
+>foo : 0n
+>"0n" : 0n
+
+=== correctUse.ts ===
+import { "0n" as foo } from "./foo";
+>foo : 0n
+
+export { foo as "0n" };
+>foo : 0n
+>"0n" : 0n
+
+=== badImport.ts ===
+import { 0n as foo } from "./foo";
+>0n as foo : foo
+>0n : 0n
+>from : any
+>"./foo" : "./foo"
+
+=== badImport2.ts ===
+import { foo as 0n } from "./foo";
+>foo : any
+> : any
+>from : any
+>"./foo" : "./foo"
+
+=== badExport.ts ===
+export { foo as 0n };
+>foo : any
+> : any
+>0n : 0n
+
+=== badExport2.ts ===
+export { 0n as foo };
+>0n as foo : foo
+>0n : 0n
+

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=typesfirst).errors.txt

@@ -0,0 +1,72 @@
+badExport.ts(1,10): error TS2304: Cannot find name 'foo'.
+badExport.ts(1,17): error TS1003: Identifier expected.
+badExport.ts(1,20): error TS1128: Declaration or statement expected.
+badExport2.ts(1,10): error TS1003: Identifier expected.
+badExport2.ts(1,16): error TS2304: Cannot find name 'foo'.
+badExport2.ts(1,20): error TS1128: Declaration or statement expected.
+badImport.ts(1,10): error TS1003: Identifier expected.
+badImport.ts(1,10): error TS1141: String literal expected.
+badImport.ts(1,16): error TS2304: Cannot find name 'foo'.
+badImport.ts(1,20): error TS1128: Declaration or statement expected.
+badImport.ts(1,22): error TS1434: Unexpected keyword or identifier.
+badImport.ts(1,22): error TS2304: Cannot find name 'from'.
+badImport2.ts(1,17): error TS1003: Identifier expected.
+badImport2.ts(1,17): error TS1141: String literal expected.
+badImport2.ts(1,20): error TS1128: Declaration or statement expected.
+badImport2.ts(1,22): error TS1434: Unexpected keyword or identifier.
+badImport2.ts(1,22): error TS2304: Cannot find name 'from'.
+
+
+==== foo.ts (0 errors) ====
+    const foo = 0n;
+    export { foo as "0n" };
+    
+==== correctUse.ts (0 errors) ====
+    import { "0n" as foo } from "./foo";
+    export { foo as "0n" };
+    
+==== badImport.ts (6 errors) ====
+    import { 0n as foo } from "./foo";
+             ~~
+!!! error TS1003: Identifier expected.
+             ~~~~~~~~~
+!!! error TS1141: String literal expected.
+                   ~~~
+!!! error TS2304: Cannot find name 'foo'.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+                         ~~~~
+!!! error TS1434: Unexpected keyword or identifier.
+                         ~~~~
+!!! error TS2304: Cannot find name 'from'.
+    
+==== badImport2.ts (5 errors) ====
+    import { foo as 0n } from "./foo";
+                    ~~
+!!! error TS1003: Identifier expected.
+                    ~~
+!!! error TS1141: String literal expected.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+                         ~~~~
+!!! error TS1434: Unexpected keyword or identifier.
+                         ~~~~
+!!! error TS2304: Cannot find name 'from'.
+    
+==== badExport.ts (3 errors) ====
+    export { foo as 0n };
+             ~~~
+!!! error TS2304: Cannot find name 'foo'.
+                    ~~
+!!! error TS1003: Identifier expected.
+                       ~
+!!! error TS1128: Declaration or statement expected.
+    
+==== badExport2.ts (3 errors) ====
+    export { 0n as foo };
+             ~~
+!!! error TS1003: Identifier expected.
+                   ~~~
+!!! error TS2304: Cannot find name 'foo'.
+                       ~
+!!! error TS1128: Declaration or statement expected.

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=typesfirst).js

@@ -0,0 +1,44 @@
+//// [tests/cases/compiler/bigintArbirtraryIdentifier.ts] ////
+
+//// [foo.ts]
+const foo = 0n;
+export { foo as "0n" };
+
+//// [correctUse.ts]
+import { "0n" as foo } from "./foo";
+export { foo as "0n" };
+
+//// [badImport.ts]
+import { 0n as foo } from "./foo";
+
+//// [badImport2.ts]
+import { foo as 0n } from "./foo";
+
+//// [badExport.ts]
+export { foo as 0n };
+
+//// [badExport2.ts]
+export { 0n as foo };
+
+//// [foo.js]
+const foo = 0n;
+export { foo as "0n" };
+//// [correctUse.js]
+import { "0n" as foo } from "./foo";
+export { foo as "0n" };
+//// [badImport.js]
+from;
+"./foo";
+export {};
+//// [badImport2.js]
+from;
+"./foo";
+export {};
+//// [badExport.js]
+export { foo as  };
+0n;
+;
+//// [badExport2.js]
+0n;
+;
+export {};

tsc/testdata/baselines/reference/compiler/bigintArbirtraryIdentifier(checkorder=typesfirst).symbols

@@ -0,0 +1,34 @@
+//// [tests/cases/compiler/bigintArbirtraryIdentifier.ts] ////
+
+=== foo.ts ===
+const foo = 0n;
+>foo : Symbol(foo, Decl(foo.ts, 0, 5))
+
+export { foo as "0n" };
+>foo : Symbol(foo, Decl(foo.ts, 0, 5))
+>"0n" : Symbol("0n", Decl(foo.ts, 1, 8))
+
+=== correctUse.ts ===
+import { "0n" as foo } from "./foo";
+>foo : Symbol(foo, Decl(correctUse.ts, 0, 8))
+
+export { foo as "0n" };
+>foo : Symbol(foo, Decl(correctUse.ts, 0, 8))
+>"0n" : Symbol("0n", Decl(correctUse.ts, 1, 8))
+
+=== badImport.ts ===
+import { 0n as foo } from "./foo";
+>foo : Symbol(foo)
+
+=== badImport2.ts ===
+import { foo as 0n } from "./foo";
+> : Symbol((Missing), Decl(badImport2.ts, 0, 8))
+
+=== badExport.ts ===
+export { foo as 0n };
+> : Symbol((Missing), Decl(badExport.ts, 0, 8))
+
+=== badExport2.ts ===
+export { 0n as foo };
+>foo : Symbol(foo)
+