Remove the TypeChecked node flag

Its last use was in reportNonexistentProperty, which kept both a set of
(name, containing type, JS) keys and the flag on the name's node. The
flag already stopped a second report for the node on any containing
type, so the keyed set never caught anything the flag did not.

Keep a single set of reported name nodes instead. Reports only run
while checking, so this stays checking-only state, as the keyed set was.

Author: jakebailey

tsc/internal/checker/checker.go

@@ -263,14 +263,6 @@ type PropertiesTypesKey struct {
 	includeOrigin bool
 }
 
-// NonExistentPropertyKey
-
-type NonExistentPropertyKey struct {
-	propNode       *ast.Node
-	containingType *Type
-	isUncheckedJS  bool
-}
-
 // FlowLoopKey
 
 type FlowLoopKey struct {
@@ -1025,7 +1017,7 @@ type memoStore struct {
 	ambientModules                          []*ast.Symbol
 	reportedUnreachableNodes                memoSet[*ast.Node]
 	checkedRegularExpressions               memoSet[*ast.Node]
-	nonExistentProperties                   collections.Set[NonExistentPropertyKey]
+	nonExistentPropertyNodes                collections.Set[*ast.Node] // Property names reported as nonexistent
 	deferredDiagnosticCallbacks             []func(c *Checker)
 	memoStates                              map[memoKey]*memoState // Memo state of results computed by queries; see memo.go
 	stateFilter                             []uint64               // Memo keys that may have a memo state; see memoState
@@ -12141,16 +12133,12 @@ func (c *Checker) reportNonexistentProperty(propNode *ast.Node, containingType *
 		c.recordEffect(func(c *Checker) { c.reportNonexistentProperty(propNode, containingType, isUncheckedJS) })
 		return
 	}
-	key := NonExistentPropertyKey{propNode, containingType, isUncheckedJS}
-	if c.nonExistentProperties.Has(key) {
+	// Only the first report for a name is made, even if it is reported again
+	// on another containing type.
+	if c.nonExistentPropertyNodes.Has(propNode) {
 		return
 	}
-	c.nonExistentProperties.Add(key)
-	links := c.nodeLinks.Get(propNode)
-	if links.flags&NodeCheckFlagsTypeChecked != 0 {
-		return // error already made/in progress
-	}
-	links.flags |= NodeCheckFlagsTypeChecked
+	c.nonExistentPropertyNodes.Add(propNode)
 	if ast.IsJSDocNameReferenceContext(propNode) {
 		return
 	}

tsc/internal/checker/checker_test.go

@@ -592,7 +592,7 @@ var unmemoizedCacheFields = map[string]string{
 	"memoStore.mu":                                      unmemoizedMemoState,
 	"memoStore.diagnostics":                             unmemoizedChecking,
 	"memoStore.suggestionDiagnostics":                   unmemoizedChecking,
-	"memoStore.nonExistentProperties":                   unmemoizedChecking,
+	"memoStore.nonExistentPropertyNodes":                unmemoizedChecking,
 	"memoStore.deferredDiagnosticCallbacks":             unmemoizedChecking,
 	"SymbolReferenceLinks.referenceKinds":               unmemoizedChecking,
 	"AliasSymbolLinks.referenced":                       unmemoizedMark,

tsc/internal/checker/types.go

@@ -415,7 +415,6 @@ type NodeCheckFlags uint32
 
 const (
 	NodeCheckFlagsNone                                     NodeCheckFlags = 0
-	NodeCheckFlagsTypeChecked                              NodeCheckFlags = 1 << 0  // Node has been type checked
 	NodeCheckFlagsContextChecked                           NodeCheckFlags = 1 << 6  // Contextual types have been assigned
 	NodeCheckFlagsSignatureContextChecked                  NodeCheckFlags = 1 << 7  // Signature of a contextually typed function has been checked
 	NodeCheckFlagsEnumValuesComputed                       NodeCheckFlags = 1 << 10 // Values for enum members have been computed, and any errors have been reported for them.