From d209285c02d2242bae2363d6a0ce3857f34ce79c Mon Sep 17 00:00:00 2001 From: maxliux5 <5958865+maxliux5@users.noreply.github.com> Date: Sat, 21 Nov 2026 15:11:30 +0000 Subject: [PATCH 1/2] fix(workbench): unify composer and queued message surfaces Signed-off-by: maxliux5 <5958865+maxliux5@users.noreply.github.com> --- apps/workbench/packages/web/src/styles.css | 30 +++++++++------------- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/apps/workbench/packages/web/src/styles.css b/apps/workbench/packages/web/src/styles.css index fd67ab3fa1..4234cb4e7a 100644 --- a/apps/workbench/packages/web/src/styles.css +++ b/apps/workbench/packages/web/src/styles.css @@ -24,8 +24,6 @@ /* The top bar on a wide screen: frosted, but far less see-through than the phone's bands. */ --glass-bar: 80%; --glass-bar-blur: 14px; - /* On a wide screen the composer's own soft shadow does the same job, following its round corners. */ - --glass-halo: 0 10px 40px rgba(31, 30, 28, 0.11), 0 2px 8px rgba(31, 30, 28, 0.05); --thread-peek-width: min(560px, 44vw); --z-thread-peek: 40; --z-desk-spread: 44; @@ -194,7 +192,6 @@ --shadow-card: 0 1px 2px rgba(0, 0, 0, 0.3), 0 6px 20px rgba(0, 0, 0, 0.25); --glass-rim: inset 0 0 0 1px rgba(255, 255, 255, 0.066), inset 0 1px 1px rgba(255, 255, 255, 0.12); --glass-lift: 0 2px 10px rgba(0, 0, 0, 0.2); - --glass-halo: 0 10px 40px rgba(0, 0, 0, 0.5), 0 2px 8px rgba(0, 0, 0, 0.3); color-scheme: dark; } } @@ -257,7 +254,6 @@ --shadow-card: 0 1px 2px rgba(0, 0, 0, 0.3), 0 6px 20px rgba(0, 0, 0, 0.25); --glass-rim: inset 0 0 0 1px rgba(255, 255, 255, 0.066), inset 0 1px 1px rgba(255, 255, 255, 0.12); --glass-lift: 0 2px 10px rgba(0, 0, 0, 0.2); - --glass-halo: 0 10px 40px rgba(0, 0, 0, 0.5), 0 2px 8px rgba(0, 0, 0, 0.3); color-scheme: dark; } @@ -2370,8 +2366,9 @@ html.list-open body { flex-direction: column; border: 1px solid var(--border); border-radius: 22px; - background: var(--surface); - box-shadow: var(--shadow-card); + position: relative; + background: var(--bg); + box-shadow: none; } /* Which agent and directory: a quiet strip on top of the card. */ @@ -2383,7 +2380,7 @@ html.list-open body { padding: 4px 10px; border-bottom: 1px solid var(--border); border-radius: 22px 22px 0 0; - background: var(--surface-2); + background: transparent; font-size: 13px; } @@ -7263,7 +7260,8 @@ div.file-card:hover { background: var(--surface); } display: flex; flex-direction: column; gap: 2px; - padding: 8px 10px 0; + padding: 8px 10px; + border-bottom: 1px solid var(--border); } .queue-item { @@ -7273,7 +7271,7 @@ div.file-card:hover { background: var(--surface); } min-height: 34px; padding: 0 4px 0 8px; border-radius: var(--radius-sm); - background: var(--surface-2); + background: transparent; font-size: 13.5px; } @@ -14727,12 +14725,11 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } .command-menu, .coord-mention-menu, .action-sheet-card { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-pop-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } /* Single-line fields share the buttons' pill, so a row of controls reads as one family. */ .field input, .field-inline input, .auto-setting-line input, .personal-setting-line input, .general-select { border-radius: var(--radius-pill); padding-inline: 16px; } -.glass-control, .topbar .menu-btn, .topbar-actions, .composer-box { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } +.glass-control, .topbar .menu-btn, .topbar-actions { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } .glass-control { border-radius: var(--radius-pill); } .topbar-actions { border-radius: var(--radius-pill); padding: 2px 4px; } @media (max-width: 899.98px) { .topbar-actions { padding: 0 2px; } } .topbar-actions .icon-btn { background: transparent; border: 0; box-shadow: none; } -.composer-box { position: relative; } /* Glass needs a backdrop: the scroller spans the chrome, while its padding keeps the first and last lines clear at rest. No extra rounded container is drawn around the top bar. */ @@ -14773,7 +14770,7 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } it): a notice or the read-only handover note stacked over the box takes no part. The slot's children sit above both layers, and a menu opening upward from the box still covers what is above it. The wide screen draws neither: a band there reads as a grey bar with square corners around a round box, so the - box gets a soft shadow of its own instead. */ + opaque field keeps its own hairline boundary instead. */ .main:has(> .composer-slot) { --composer-clear: 48px; } .composer-slot > :not(.action-sheet) { position: relative; z-index: 1; } .composer-slot::before, .composer-slot::after { content: ''; position: absolute; left: 0; right: 0; bottom: 0; height: calc(var(--chat-composer-h, 0px) + 40px); pointer-events: none; } @@ -14792,7 +14789,6 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } } @media (min-width: 900px) { .composer-slot::before, .composer-slot::after { display: none; } - .composer-box { box-shadow: var(--glass-rim), var(--glass-halo); } } /* The docked selection menu hides the box but not the slot, which stays as tall as the box with its notes: the edge would wash a bare stretch of the thread above the menu. The menu is glass itself. */ @@ -14833,21 +14829,20 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } .menu-float { min-width: min(280px, calc(100vw - 24px)); } } @supports not ((backdrop-filter: blur(1px)) or (-webkit-backdrop-filter: blur(1px))) { - .glass-control, .topbar .menu-btn, .topbar-actions, .composer-box, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); } + .glass-control, .topbar .menu-btn, .topbar-actions, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); } .main:has(> .composer-slot) > .topbar::before { display: none; } .main:has(> .composer-slot) > .topbar::after { background: linear-gradient(var(--bg) calc(100% - 30px), transparent); } .composer-slot::before { display: none; } .composer-slot::after { background: linear-gradient(transparent, var(--bg) 40px); } } @media (prefers-reduced-transparency: reduce) { - .glass-control, .topbar .menu-btn, .topbar-actions, .composer-box, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); -webkit-backdrop-filter: none; backdrop-filter: none; } + .glass-control, .topbar .menu-btn, .topbar-actions, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); -webkit-backdrop-filter: none; backdrop-filter: none; } .main:has(> .composer-slot) > .topbar::before { display: none; } .main:has(> .composer-slot) > .topbar::after { background: linear-gradient(var(--bg) calc(100% - 30px), transparent); -webkit-backdrop-filter: none; backdrop-filter: none; } .composer-slot::before { display: none; } .composer-slot::after { background: linear-gradient(transparent, var(--bg) 40px); } } -/* A wide screen draws the composer solid: an opaque card with its soft halo, and the conversation - ends above it instead of sliding under a translucent box. With no status area above it, the top bar +/* On a wide screen the conversation ends above the opaque input field. With no status area above it, the top bar is frosted across its whole row: mostly the page's colour over a strong blur, so what scrolls under it shows only as a soft shadow and never runs into the title, fading out below the row. */ @media (min-width: 900px) { @@ -14859,7 +14854,6 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } padding-bottom: var(--composer-clear); scroll-padding-bottom: var(--composer-clear); } - .composer-box { background: var(--surface); border-color: var(--border); box-shadow: var(--glass-halo); -webkit-backdrop-filter: none; backdrop-filter: none; } } @media (min-width: 900px) and (prefers-reduced-transparency: reduce) { .main:has(> .composer-slot) > .topbar::after { background: var(--bg); } From b19e73a8361c9fd3ed916be97807be07d3e0dd7e Mon Sep 17 00:00:00 2001 From: maxliux5 <5958865+maxliux5@users.noreply.github.com> Date: Sat, 21 Nov 2026 15:40:04 +0000 Subject: [PATCH 2/2] fix(workbench): scope composer surface to Codex light Signed-off-by: maxliux5 <5958865+maxliux5@users.noreply.github.com> --- .../packages/e2e/test/composer-theme.spec.mjs | 62 +++++++++++++++++++ apps/workbench/packages/web/src/styles.css | 48 ++++++++++---- 2 files changed, 98 insertions(+), 12 deletions(-) create mode 100644 apps/workbench/packages/e2e/test/composer-theme.spec.mjs diff --git a/apps/workbench/packages/e2e/test/composer-theme.spec.mjs b/apps/workbench/packages/e2e/test/composer-theme.spec.mjs new file mode 100644 index 0000000000..793784c7aa --- /dev/null +++ b/apps/workbench/packages/e2e/test/composer-theme.spec.mjs @@ -0,0 +1,62 @@ +import { test } from 'node:test'; +import assert from 'node:assert/strict'; +import { readFileSync } from 'node:fs'; +import { tsImport } from 'tsx/esm/api'; +import { launchBrowser } from '../harness.mjs'; + +const { PALETTES } = await tsImport('../../web/src/appearance.ts', import.meta.url); +const css = readFileSync(new URL('../../web/src/styles.css', import.meta.url), 'utf8'); + +// The scope is intentional: only Codex light changes. Unrelated themes retain +// their existing surface, filled queue rows and desktop/mobile material. +test('composer correction stays in Codex light across every shipped palette', async t => { + const browser = await launchBrowser(); + const page = await browser.newPage(); + try { + for (const { id } of PALETTES) for (const theme of ['light', 'dark']) for (const width of [1280, 390]) { + await t.test(`${id} ${theme} ${width}`, async () => { + await page.setViewportSize({ width, height: 844 }); + await page.emulateMedia({ colorScheme: theme }); + await page.setContent(` +
+
Workspace
+
QueuedKeep the queued message readable.
+ +
`); + const actual = await page.evaluate(() => { + const style = selector => getComputedStyle(document.querySelector(selector)); + const probe = document.createElement('div'); document.body.append(probe); + const token = (property, name) => { + probe.style.setProperty(property, `var(${name})`); + return getComputedStyle(probe).getPropertyValue(property); + }; + const values = { + fill: style('.composer-box').backgroundColor, queue: style('.queue-item').backgroundColor, + context: style('.composer-context').backgroundColor, shadow: style('.composer-box').boxShadow, + blur: style('.composer-box').backdropFilter, queueBottom: style('.queue').paddingBottom, + canvas: token('background-color', '--bg'), surface: token('background-color', '--surface'), + row: token('background-color', '--surface-2'), glass: token('background-color', '--glass-bg'), + halo: token('box-shadow', '--glass-halo'), glassShadow: token('box-shadow', '--glass-shadow'), + glassFilter: token('backdrop-filter', '--glass-filter'), + }; + probe.remove(); return values; + }); + if (id === 'codex' && theme === 'light') { + assert.equal(actual.fill, actual.canvas); + assert.equal(actual.queue, 'rgba(0, 0, 0, 0)'); + assert.equal(actual.context, 'rgba(0, 0, 0, 0)'); + assert.equal(actual.shadow, 'none'); + assert.equal(actual.blur, 'none'); + assert.equal(actual.queueBottom, '8px'); + } else { + assert.equal(actual.fill, width >= 900 ? actual.surface : actual.glass); + assert.equal(actual.queue, actual.row); + assert.equal(actual.context, actual.row); + assert.equal(actual.shadow, width >= 900 ? actual.halo : actual.glassShadow); + assert.equal(actual.blur, width >= 900 ? 'none' : actual.glassFilter); + assert.equal(actual.queueBottom, '0px'); + } + }); + } + } finally { await browser.close(); } +}); diff --git a/apps/workbench/packages/web/src/styles.css b/apps/workbench/packages/web/src/styles.css index 4234cb4e7a..d1dcfee0ac 100644 --- a/apps/workbench/packages/web/src/styles.css +++ b/apps/workbench/packages/web/src/styles.css @@ -24,6 +24,8 @@ /* The top bar on a wide screen: frosted, but far less see-through than the phone's bands. */ --glass-bar: 80%; --glass-bar-blur: 14px; + /* On a wide screen the composer's own soft shadow does the same job, following its round corners. */ + --glass-halo: 0 10px 40px rgba(31, 30, 28, 0.11), 0 2px 8px rgba(31, 30, 28, 0.05); --thread-peek-width: min(560px, 44vw); --z-thread-peek: 40; --z-desk-spread: 44; @@ -192,6 +194,7 @@ --shadow-card: 0 1px 2px rgba(0, 0, 0, 0.3), 0 6px 20px rgba(0, 0, 0, 0.25); --glass-rim: inset 0 0 0 1px rgba(255, 255, 255, 0.066), inset 0 1px 1px rgba(255, 255, 255, 0.12); --glass-lift: 0 2px 10px rgba(0, 0, 0, 0.2); + --glass-halo: 0 10px 40px rgba(0, 0, 0, 0.5), 0 2px 8px rgba(0, 0, 0, 0.3); color-scheme: dark; } } @@ -254,6 +257,7 @@ --shadow-card: 0 1px 2px rgba(0, 0, 0, 0.3), 0 6px 20px rgba(0, 0, 0, 0.25); --glass-rim: inset 0 0 0 1px rgba(255, 255, 255, 0.066), inset 0 1px 1px rgba(255, 255, 255, 0.12); --glass-lift: 0 2px 10px rgba(0, 0, 0, 0.2); + --glass-halo: 0 10px 40px rgba(0, 0, 0, 0.5), 0 2px 8px rgba(0, 0, 0, 0.3); color-scheme: dark; } @@ -479,6 +483,24 @@ --shadow-selected: inset 0 0 0 1px #a98d7f; } +/* Only the Codex light composer shares its canvas. Other palettes and dark mode + retain their existing surface, queue fill and material. */ +:root[data-palette='codex'][data-theme='light'] .composer-box { + background: var(--bg); + border-color: var(--border); + box-shadow: none; + -webkit-backdrop-filter: none; + backdrop-filter: none; +} +:root[data-palette='codex'][data-theme='light'] .composer-context, +:root[data-palette='codex'][data-theme='light'] .queue-item { + background: transparent; +} +:root[data-palette='codex'][data-theme='light'] .queue { + padding-bottom: 8px; + border-bottom: 1px solid var(--border); +} + /* "claude" pins three tokens of its own, for the same reason: the hairline (#e4e4e4), the grey a selected sidebar row wears (#e1e1e1) and the placeholder grey (#787878), each measured. */ [data-palette='claude']:not([data-palette='paper']) { @@ -2366,9 +2388,8 @@ html.list-open body { flex-direction: column; border: 1px solid var(--border); border-radius: 22px; - position: relative; - background: var(--bg); - box-shadow: none; + background: var(--surface); + box-shadow: var(--shadow-card); } /* Which agent and directory: a quiet strip on top of the card. */ @@ -2380,7 +2401,7 @@ html.list-open body { padding: 4px 10px; border-bottom: 1px solid var(--border); border-radius: 22px 22px 0 0; - background: transparent; + background: var(--surface-2); font-size: 13px; } @@ -7260,8 +7281,7 @@ div.file-card:hover { background: var(--surface); } display: flex; flex-direction: column; gap: 2px; - padding: 8px 10px; - border-bottom: 1px solid var(--border); + padding: 8px 10px 0; } .queue-item { @@ -7271,7 +7291,7 @@ div.file-card:hover { background: var(--surface); } min-height: 34px; padding: 0 4px 0 8px; border-radius: var(--radius-sm); - background: transparent; + background: var(--surface-2); font-size: 13.5px; } @@ -14725,11 +14745,12 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } .command-menu, .coord-mention-menu, .action-sheet-card { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-pop-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } /* Single-line fields share the buttons' pill, so a row of controls reads as one family. */ .field input, .field-inline input, .auto-setting-line input, .personal-setting-line input, .general-select { border-radius: var(--radius-pill); padding-inline: 16px; } -.glass-control, .topbar .menu-btn, .topbar-actions { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } +.glass-control, .topbar .menu-btn, .topbar-actions, .composer-box { border: 1px solid transparent; background: var(--glass-lighting), var(--glass-bg); box-shadow: var(--glass-shadow); -webkit-backdrop-filter: var(--glass-filter); backdrop-filter: var(--glass-filter); } .glass-control { border-radius: var(--radius-pill); } .topbar-actions { border-radius: var(--radius-pill); padding: 2px 4px; } @media (max-width: 899.98px) { .topbar-actions { padding: 0 2px; } } .topbar-actions .icon-btn { background: transparent; border: 0; box-shadow: none; } +.composer-box { position: relative; } /* Glass needs a backdrop: the scroller spans the chrome, while its padding keeps the first and last lines clear at rest. No extra rounded container is drawn around the top bar. */ @@ -14770,7 +14791,7 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } it): a notice or the read-only handover note stacked over the box takes no part. The slot's children sit above both layers, and a menu opening upward from the box still covers what is above it. The wide screen draws neither: a band there reads as a grey bar with square corners around a round box, so the - opaque field keeps its own hairline boundary instead. */ + box gets a soft shadow of its own instead. */ .main:has(> .composer-slot) { --composer-clear: 48px; } .composer-slot > :not(.action-sheet) { position: relative; z-index: 1; } .composer-slot::before, .composer-slot::after { content: ''; position: absolute; left: 0; right: 0; bottom: 0; height: calc(var(--chat-composer-h, 0px) + 40px); pointer-events: none; } @@ -14789,6 +14810,7 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } } @media (min-width: 900px) { .composer-slot::before, .composer-slot::after { display: none; } + .composer-box { box-shadow: var(--glass-rim), var(--glass-halo); } } /* The docked selection menu hides the box but not the slot, which stays as tall as the box with its notes: the edge would wash a bare stretch of the thread above the menu. The menu is glass itself. */ @@ -14829,20 +14851,21 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } .menu-float { min-width: min(280px, calc(100vw - 24px)); } } @supports not ((backdrop-filter: blur(1px)) or (-webkit-backdrop-filter: blur(1px))) { - .glass-control, .topbar .menu-btn, .topbar-actions, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); } + .glass-control, .topbar .menu-btn, .topbar-actions, .composer-box, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); } .main:has(> .composer-slot) > .topbar::before { display: none; } .main:has(> .composer-slot) > .topbar::after { background: linear-gradient(var(--bg) calc(100% - 30px), transparent); } .composer-slot::before { display: none; } .composer-slot::after { background: linear-gradient(transparent, var(--bg) 40px); } } @media (prefers-reduced-transparency: reduce) { - .glass-control, .topbar .menu-btn, .topbar-actions, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); -webkit-backdrop-filter: none; backdrop-filter: none; } + .glass-control, .topbar .menu-btn, .topbar-actions, .composer-box, .menu-panel, .pop-panel.anchored-pop, .selection-menu, .settings-actions, .round-btn, .jump-btn, .pet-summon, .command-menu, .coord-mention-menu, .action-sheet-card { background: var(--surface); -webkit-backdrop-filter: none; backdrop-filter: none; } .main:has(> .composer-slot) > .topbar::before { display: none; } .main:has(> .composer-slot) > .topbar::after { background: linear-gradient(var(--bg) calc(100% - 30px), transparent); -webkit-backdrop-filter: none; backdrop-filter: none; } .composer-slot::before { display: none; } .composer-slot::after { background: linear-gradient(transparent, var(--bg) 40px); } } -/* On a wide screen the conversation ends above the opaque input field. With no status area above it, the top bar +/* A wide screen draws the composer solid: an opaque card with its soft halo, and the conversation + ends above it instead of sliding under a translucent box. With no status area above it, the top bar is frosted across its whole row: mostly the page's colour over a strong blur, so what scrolls under it shows only as a soft shadow and never runs into the title, fading out below the row. */ @media (min-width: 900px) { @@ -14854,6 +14877,7 @@ body:has(.settings-page, .action-sheet) .pet { display: none; } padding-bottom: var(--composer-clear); scroll-padding-bottom: var(--composer-clear); } + .composer-box { background: var(--surface); border-color: var(--border); box-shadow: var(--glass-halo); -webkit-backdrop-filter: none; backdrop-filter: none; } } @media (min-width: 900px) and (prefers-reduced-transparency: reduce) { .main:has(> .composer-slot) > .topbar::after { background: var(--bg); }