From 7add3686fd593f27d29a3ced780177bd6fcd60c2 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 10:44:08 +0100 Subject: [PATCH 01/14] Implement st suffix --- practice-tdd/get-ordinal-number.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/practice-tdd/get-ordinal-number.js b/practice-tdd/get-ordinal-number.js index 5c6291f5ed..4022152ab6 100644 --- a/practice-tdd/get-ordinal-number.js +++ b/practice-tdd/get-ordinal-number.js @@ -1,3 +1,3 @@ export function getOrdinalNumber(num) { - return "1st"; + return `${num}st`; } From e513388b69432199dab8f4394c4a705c7d4ceab7 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 11:19:57 +0100 Subject: [PATCH 02/14] Implement nd suffix --- practice-tdd/get-ordinal-number.js | 15 ++++++++++++++- practice-tdd/get-ordinal-number.test.js | 6 ++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/practice-tdd/get-ordinal-number.js b/practice-tdd/get-ordinal-number.js index 4022152ab6..fb702b33ed 100644 --- a/practice-tdd/get-ordinal-number.js +++ b/practice-tdd/get-ordinal-number.js @@ -1,3 +1,16 @@ export function getOrdinalNumber(num) { - return `${num}st`; + const lastTwoDigits = num % 100; + const lastDigits = num % 10; + + if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { + return `${num}th`; + } else if (lastDigits === 1) { + return `${num}st`; + } else if (lastDigits === 2) { + return `${num}nd`; + } else if (lastDigits === 3) { + return `${num}rd`; + } else { + return `${num}th`; + } } diff --git a/practice-tdd/get-ordinal-number.test.js b/practice-tdd/get-ordinal-number.test.js index e23174a187..c85733d162 100644 --- a/practice-tdd/get-ordinal-number.test.js +++ b/practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,9 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); + +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(22)).toEqual("22nd"); + expect(getOrdinalNumber(112)).toEqual("112th"); +}); From e0a7c74109a0e837e065b4aedfa5b5ea14bf803d Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 11:33:30 +0100 Subject: [PATCH 03/14] Implement rd suffix --- practice-tdd/get-ordinal-number.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/practice-tdd/get-ordinal-number.test.js b/practice-tdd/get-ordinal-number.test.js index c85733d162..269e772018 100644 --- a/practice-tdd/get-ordinal-number.test.js +++ b/practice-tdd/get-ordinal-number.test.js @@ -24,3 +24,9 @@ test("should append 'nd' for numbers ending with 2, except those ending with 12" expect(getOrdinalNumber(22)).toEqual("22nd"); expect(getOrdinalNumber(112)).toEqual("112th"); }); + +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(23)).toEqual("23rd"); + expect(getOrdinalNumber(113)).toEqual("113th"); +}); From 87f874be0ea82cb6f8c0b7a06970bb6a36a71572 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 11:45:38 +0100 Subject: [PATCH 04/14] Implement th suffix --- practice-tdd/get-ordinal-number.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/practice-tdd/get-ordinal-number.test.js b/practice-tdd/get-ordinal-number.test.js index 269e772018..8947ecefaf 100644 --- a/practice-tdd/get-ordinal-number.test.js +++ b/practice-tdd/get-ordinal-number.test.js @@ -30,3 +30,9 @@ test("should append 'rd' for numbers ending with 3, except those ending with 13" expect(getOrdinalNumber(23)).toEqual("23rd"); expect(getOrdinalNumber(113)).toEqual("113th"); }); + +test("should append 'th' for other numbers", () => { + expect(getOrdinalNumber(4)).toEqual("4th"); + expect(getOrdinalNumber(24)).toEqual("24th"); + expect(getOrdinalNumber(114)).toEqual("114th"); +}); From c6c50009dbaa4fa965e25cec8f43b18368d1812b Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 11:54:06 +0100 Subject: [PATCH 05/14] Complete ordinal number tests --- practice-tdd/get-ordinal-number.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/practice-tdd/get-ordinal-number.test.js b/practice-tdd/get-ordinal-number.test.js index 8947ecefaf..9a48f79218 100644 --- a/practice-tdd/get-ordinal-number.test.js +++ b/practice-tdd/get-ordinal-number.test.js @@ -36,3 +36,9 @@ test("should append 'th' for other numbers", () => { expect(getOrdinalNumber(24)).toEqual("24th"); expect(getOrdinalNumber(114)).toEqual("114th"); }); + +test("should append 'th' for numbers ending with 11, 12, 13", () => { + expect(getOrdinalNumber(11)).toEqual("11th"); + expect(getOrdinalNumber(12)).toEqual("12th"); + expect(getOrdinalNumber(13)).toEqual("13th"); +}); From 34c5ab9298e751a9aa85d48c154a7c8a923b2e65 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 12:49:26 +0100 Subject: [PATCH 06/14] Implement countChar function --- practice-tdd/count.js | 9 ++++++++- practice-tdd/count.test.js | 5 +++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/practice-tdd/count.js b/practice-tdd/count.js index 5518c57123..0b461dfd4b 100644 --- a/practice-tdd/count.js +++ b/practice-tdd/count.js @@ -1,3 +1,10 @@ export function countChar(stringOfCharacters, findCharacter) { - return 5 + let count = 0; + + for (const character of stringOfCharacters) { + if (character === findCharacter) { + count++; + } + } + return count; } diff --git a/practice-tdd/count.test.js b/practice-tdd/count.test.js index cb3aaae591..355944b99c 100644 --- a/practice-tdd/count.test.js +++ b/practice-tdd/count.test.js @@ -22,3 +22,8 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. + +test("should return 0 when character does not occur", () => { + const count = countChar("hello", "z"); + expect(count).toEqual(0); +}); From a074c862622e16e281c2fb8c734b73bad931bcdb Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 15 Oct 2026 13:20:14 +0100 Subject: [PATCH 07/14] Implement repeatStr function --- practice-tdd/repeat-str.js | 13 +++++++++---- practice-tdd/repeat-str.test.js | 14 ++++++++++++++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/practice-tdd/repeat-str.js b/practice-tdd/repeat-str.js index af273f3b01..771ec82fe2 100644 --- a/practice-tdd/repeat-str.js +++ b/practice-tdd/repeat-str.js @@ -1,5 +1,10 @@ -export function repeatStr() { - // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). - // The goal is to re-implement that function, not to use it. - return "hellohellohello"; +export function repeatStr(str, count) { + if (count < 0) { + throw new Error("Count cannot be negative"); + } + let result = ""; + for (let i = 0; i < count; i++) { + result += str; + } + return result; } diff --git a/practice-tdd/repeat-str.test.js b/practice-tdd/repeat-str.test.js index 8a7036102b..895133fb8a 100644 --- a/practice-tdd/repeat-str.test.js +++ b/practice-tdd/repeat-str.test.js @@ -16,6 +16,20 @@ test("should repeat the string count times", () => { expect(repeatedStr).toEqual("hellohellohello"); }); +test("should return the original string when count is 1", () => { + const str = "hello"; + const count = 1; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual("hello"); +}); + +test("should return an empty string when count is 0", () => { + const str = "hello"; + const count = 0; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual(""); +}); + // Case: handle count of 1: // Given a target string `str` and a `count` equal to 1, // When the repeatStr function is called with these inputs, From 027df8cfb17c3619c2b88556e70985bf3364f8c8 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Sun, 1 Nov 2026 15:36:21 +0000 Subject: [PATCH 08/14] Complete get angle type tests --- .../1-get-angle-type.test.js | 46 ++++++++++++++++++- .../implement/1-get-angle-type.js | 19 +++++++- 2 files changed, 63 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index cf50f6cade..89c99f892d 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -6,7 +6,51 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests to cover all cases, including boundary and invalid cases. // Example: Identify Right Angles -test("Classifies right angles", () => { +test("returns right angle for 90", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); + +test("returns invalid angle for 0", () => { + const result = getAngleType(0); + assert.equal(result, "Invalid angle"); +}); + +test("returns acute angle for 1", () => { + const result = getAngleType(1); + assert.equal(result, "Acute angle"); +}); + +test("returns acute angle for 89", () => { + const result = getAngleType(89); + assert.equal(result, "Acute angle"); +}); +test("returns obtuse angle for 91", () => { + const result = getAngleType(91); + assert.equal(result, "Obtuse angle"); +}); + +test("returns obtuse angle for 179", () => { + const result = getAngleType(179); + assert.equal(result, "Obtuse angle"); +}); + +test("returns straight angle for 180", () => { + const result = getAngleType(180); + assert.equal(result, "Straight angle"); +}); + +test("returns reflex angle for 359", () => { + const result = getAngleType(359); + assert.equal(result, "Reflex angle"); +}); + +test("returns invalid angle for 360", () => { + const result = getAngleType(360); + assert.equal(result, "Invalid angle"); +}); + +test("returns invalid angle for -1", () => { + const result = getAngleType(-1); + assert.equal(result, "Invalid angle"); +}); diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 8a6fba0504..928be482b5 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,5 +17,22 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - // TODO: Implement this function + if (angle <= 0 || angle >= 360) { + return "Invalid angle"; + } + + if (angle < 90) { + return "Acute angle"; + } + if (angle === 90) { + return "Right angle"; + } + if (angle < 180) { + return "Obtuse angle"; + } + + if (angle === 180) { + return "Straight angle"; + } + return "Reflex angle"; } From 5492092128f3beb64176419fe844350cca20e8e3 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Sun, 1 Nov 2026 16:14:35 +0000 Subject: [PATCH 09/14] Complete proper fraction tests --- .../2-is-proper-fraction.test.js | 28 +++++++++++++++++++ .../implement/2-is-proper-fraction.js | 2 +- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index a290846058..5f1e43d706 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -10,3 +10,31 @@ test("Basic proper fraction", () => { // Example: 1/2 is a proper fraction assert.equal(isProperFraction(1, 2), true); }); + +test("returns true for -1 and -2", () => { + assert.equal(isProperFraction(-1, -2), true); +}); + +test("returns true for zero numerator", () => { + assert.equal(isProperFraction(0, 5), true); +}); + +test("returns false for zero denominator", () => { + assert.equal(isProperFraction(1, 0), false); +}); + +test("returns true for negative numerator and positive denominator", () => { + assert.equal(isProperFraction(-1, 2), true); +}); + +test("returns true for positive numerator and negative denominator", () => { + assert.equal(isProperFraction(1, -2), true); +}); + +test("returns false for equal numerator and denominator", () => { + assert.equal(isProperFraction(-2, 2), false); +}); + +test("returns false when absolute numerator is greater than denominator", () => { + assert.equal(isProperFraction(-3, 2), false); +}); diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index f983800f00..91194267d2 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,5 +14,5 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - // TODO: Implement this function + return Math.abs(numerator) < Math.abs(denominator); } From a78a68a91a3c22397e89a66958cf5de99d6ba132 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Sun, 1 Nov 2026 17:22:18 +0000 Subject: [PATCH 10/14] complete get card value tests --- .../3-get-card-value.test.js | 43 +++++++++++++++++-- .../implement/3-get-card-value.js | 25 ++++++++++- 2 files changed, 63 insertions(+), 5 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index f5092d9b10..825fa56e40 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -3,14 +3,49 @@ import test from "node:test"; import { getCardValue } from "../implement/3-get-card-value.js"; -// TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. - test("Valid single-digit card", () => { assert.equal(getCardValue("9♠"), 9); }); test("Arbitrary non-card string", () => { - assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); + assert.throws( + () => getCardValue("invalid"), + /Invalid suit: "d"/, + "Expected clear error" + ); +}); + +test("return 11 for an ace in every suit", () => { + const suits = ["♠", "♥", "♦", "♣"]; + + for (const suit of suits) { + assert.equal(getCardValue(`A${suit}`), 11); + } +}); + +test("returns 10 for face cards in every suit", () => { + const faceCards = ["J", "Q", "K"]; + const suits = ["♠", "♥", "♦", "♣"]; + + for (const rank of faceCards) { + for (const suit of suits) { + assert.equal(getCardValue(`${rank}${suit}`), 10); + } + } }); -// TODO: What other invalid card cases can you think of? +test("returns the correct value for number cards", () => { + const numberCards = ["2", "3", "4", "5", "6", "7", "8", "9", "10"]; + + for (const rank of numberCards) { + assert.equal(getCardValue(`${rank}♣`), Number(rank)); + } +}); + +test("throws an error for an invalid suit", () => { + assert.throws(() => getCardValue("9X")); +}); + +test("throws an error for an invalid rank", () => { + assert.throws(() => getCardValue("1♣")); +}); diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index 9614ab1ee9..cba6558259 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -24,5 +24,28 @@ // execute the code to ensure all tests pass. export function getCardValue(card) { - // TODO: Implement this function + if (typeof card !== "string" || card.length < 2) { + throw new Error(`Invalid card: "${card}"`); + } + + const rank = card.slice(0, -1); + const suit = card.slice(-1); + + if (!["♠", "♥", "♦", "♣"].includes(suit)) { + throw new Error(`Invalid suit: "${suit}"`); + } + + if (rank === "A") { + return 11; + } + + if (["J", "Q", "K"].includes(rank)) { + return 10; + } + + if (["2", "3", "4", "5", "6", "7", "8", "9", "10"].includes(rank)) { + return Number(rank); + } + + throw new Error(`Invalid rank: "${rank}"`); } From d83d71d57a9d8004988b868253abf7186d864ade Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 12 Nov 2026 07:04:32 +0000 Subject: [PATCH 11/14] Add countChar edge case tests --- practice-tdd/count.test.js | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/practice-tdd/count.test.js b/practice-tdd/count.test.js index 355944b99c..b9c70b3f68 100644 --- a/practice-tdd/count.test.js +++ b/practice-tdd/count.test.js @@ -17,13 +17,23 @@ test("should count multiple occurrences of a character", () => { expect(count).toEqual(5); }); -// Scenario: No Occurrences -// Given the input string `str`, -// And a character `char` that does not exist within `str`. -// When the function is called with these inputs, -// Then it should return 0, indicating that no occurrences of `char` were found. +test("should count occurrences in a mixed string", () => { + const count = countChar("banana", "a"); + expect(count).toEqual(3); +}); + +test("should return 0 for an empty string", () => { + const count = countChar("", "a"); + expect(count).toEqual(0); +}); test("should return 0 when character does not occur", () => { const count = countChar("hello", "z"); expect(count).toEqual(0); }); + +// Scenario: No Occurrences +// Given the input string `str`, +// And a character `char` that does not exist within `str`. +// When the function is called with these inputs, +// Then it should return 0, indicating that no occurrences of `char` were found. From 11176de5d40946a813e53d2361a194839752fdb1 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 12 Nov 2026 07:50:08 +0000 Subject: [PATCH 12/14] Revert "complete get card value tests" This reverts commit a78a68a91a3c22397e89a66958cf5de99d6ba132. --- .../3-get-card-value.test.js | 43 ++----------------- .../implement/3-get-card-value.js | 25 +---------- 2 files changed, 5 insertions(+), 63 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index 825fa56e40..f5092d9b10 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -3,49 +3,14 @@ import test from "node:test"; import { getCardValue } from "../implement/3-get-card-value.js"; +// TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. + test("Valid single-digit card", () => { assert.equal(getCardValue("9♠"), 9); }); test("Arbitrary non-card string", () => { - assert.throws( - () => getCardValue("invalid"), - /Invalid suit: "d"/, - "Expected clear error" - ); -}); - -test("return 11 for an ace in every suit", () => { - const suits = ["♠", "♥", "♦", "♣"]; - - for (const suit of suits) { - assert.equal(getCardValue(`A${suit}`), 11); - } -}); - -test("returns 10 for face cards in every suit", () => { - const faceCards = ["J", "Q", "K"]; - const suits = ["♠", "♥", "♦", "♣"]; - - for (const rank of faceCards) { - for (const suit of suits) { - assert.equal(getCardValue(`${rank}${suit}`), 10); - } - } + assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); }); -test("returns the correct value for number cards", () => { - const numberCards = ["2", "3", "4", "5", "6", "7", "8", "9", "10"]; - - for (const rank of numberCards) { - assert.equal(getCardValue(`${rank}♣`), Number(rank)); - } -}); - -test("throws an error for an invalid suit", () => { - assert.throws(() => getCardValue("9X")); -}); - -test("throws an error for an invalid rank", () => { - assert.throws(() => getCardValue("1♣")); -}); +// TODO: What other invalid card cases can you think of? diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index cba6558259..9614ab1ee9 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -24,28 +24,5 @@ // execute the code to ensure all tests pass. export function getCardValue(card) { - if (typeof card !== "string" || card.length < 2) { - throw new Error(`Invalid card: "${card}"`); - } - - const rank = card.slice(0, -1); - const suit = card.slice(-1); - - if (!["♠", "♥", "♦", "♣"].includes(suit)) { - throw new Error(`Invalid suit: "${suit}"`); - } - - if (rank === "A") { - return 11; - } - - if (["J", "Q", "K"].includes(rank)) { - return 10; - } - - if (["2", "3", "4", "5", "6", "7", "8", "9", "10"].includes(rank)) { - return Number(rank); - } - - throw new Error(`Invalid rank: "${rank}"`); + // TODO: Implement this function } From c44cf7997c923efe4837f4ab20361e81d844a8a0 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 12 Nov 2026 07:50:43 +0000 Subject: [PATCH 13/14] Revert "Complete proper fraction tests" This reverts commit 5492092128f3beb64176419fe844350cca20e8e3. --- .../2-is-proper-fraction.test.js | 28 ------------------- .../implement/2-is-proper-fraction.js | 2 +- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index 5f1e43d706..a290846058 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -10,31 +10,3 @@ test("Basic proper fraction", () => { // Example: 1/2 is a proper fraction assert.equal(isProperFraction(1, 2), true); }); - -test("returns true for -1 and -2", () => { - assert.equal(isProperFraction(-1, -2), true); -}); - -test("returns true for zero numerator", () => { - assert.equal(isProperFraction(0, 5), true); -}); - -test("returns false for zero denominator", () => { - assert.equal(isProperFraction(1, 0), false); -}); - -test("returns true for negative numerator and positive denominator", () => { - assert.equal(isProperFraction(-1, 2), true); -}); - -test("returns true for positive numerator and negative denominator", () => { - assert.equal(isProperFraction(1, -2), true); -}); - -test("returns false for equal numerator and denominator", () => { - assert.equal(isProperFraction(-2, 2), false); -}); - -test("returns false when absolute numerator is greater than denominator", () => { - assert.equal(isProperFraction(-3, 2), false); -}); diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 91194267d2..f983800f00 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,5 +14,5 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - return Math.abs(numerator) < Math.abs(denominator); + // TODO: Implement this function } From b6220673cd785a6f3fe4836bb8f80aa281bb4724 Mon Sep 17 00:00:00 2001 From: Frumentius-Rev Date: Thu, 12 Nov 2026 07:51:15 +0000 Subject: [PATCH 14/14] Revert "Complete get angle type tests" This reverts commit 027df8cfb17c3619c2b88556e70985bf3364f8c8. --- .../1-get-angle-type.test.js | 46 +------------------ .../implement/1-get-angle-type.js | 19 +------- 2 files changed, 2 insertions(+), 63 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 89c99f892d..cf50f6cade 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -6,51 +6,7 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests to cover all cases, including boundary and invalid cases. // Example: Identify Right Angles -test("returns right angle for 90", () => { +test("Classifies right angles", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); - -test("returns invalid angle for 0", () => { - const result = getAngleType(0); - assert.equal(result, "Invalid angle"); -}); - -test("returns acute angle for 1", () => { - const result = getAngleType(1); - assert.equal(result, "Acute angle"); -}); - -test("returns acute angle for 89", () => { - const result = getAngleType(89); - assert.equal(result, "Acute angle"); -}); -test("returns obtuse angle for 91", () => { - const result = getAngleType(91); - assert.equal(result, "Obtuse angle"); -}); - -test("returns obtuse angle for 179", () => { - const result = getAngleType(179); - assert.equal(result, "Obtuse angle"); -}); - -test("returns straight angle for 180", () => { - const result = getAngleType(180); - assert.equal(result, "Straight angle"); -}); - -test("returns reflex angle for 359", () => { - const result = getAngleType(359); - assert.equal(result, "Reflex angle"); -}); - -test("returns invalid angle for 360", () => { - const result = getAngleType(360); - assert.equal(result, "Invalid angle"); -}); - -test("returns invalid angle for -1", () => { - const result = getAngleType(-1); - assert.equal(result, "Invalid angle"); -}); diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 928be482b5..8a6fba0504 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,22 +17,5 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - if (angle <= 0 || angle >= 360) { - return "Invalid angle"; - } - - if (angle < 90) { - return "Acute angle"; - } - if (angle === 90) { - return "Right angle"; - } - if (angle < 180) { - return "Obtuse angle"; - } - - if (angle === 180) { - return "Straight angle"; - } - return "Reflex angle"; + // TODO: Implement this function }