From a7a1f07a719d7b1efa0a6f5622f8882bca95d5d5 Mon Sep 17 00:00:00 2001 From: sarawone Date: Sat, 7 Nov 2026 12:14:02 +0000 Subject: [PATCH 1/2] improving code --- .../common_prefix/common_prefix.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py index f4839e70..b7b29eeb 100644 --- a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py +++ b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py @@ -7,12 +7,15 @@ def find_longest_common_prefix(strings: List[str]): In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned. """ + if len(strings)<2: + return "" + sorted_strings = sorted(strings) longest = "" - for string_index, string in enumerate(strings): - for other_string in strings[string_index+1:]: - common = find_common_prefix(string, other_string) - if len(common) > len(longest): - longest = common + + for i in range (len(sorted_strings)-1): + common = find_common_prefix(sorted_strings[i],sorted_strings[i+1]) + if len(common)> len(longest): + longest = common return longest From 7e0cca691a4696754f0f5af0b103560e987a3432 Mon Sep 17 00:00:00 2001 From: sarawone Date: Sat, 7 Nov 2026 12:49:11 +0000 Subject: [PATCH 2/2] letter_count_improve_pre_computing --- .../count_letters/count_letters.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index 62c3ec07..d34fd9ca 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -2,13 +2,14 @@ def count_letters(s: str) -> int: """ count_letters returns the number of letters which only occur in upper case in the passed string. """ + only_lower = set() + for letter in s: + if letter.islower(): + only_lower.add(letter) + only_upper = set() for letter in s: - if is_upper_case(letter): - if letter.lower() not in s: + if letter.isupper(): + if letter.lower() not in only_lower: only_upper.add(letter) - return len(only_upper) - - -def is_upper_case(letter: str) -> bool: - return letter == letter.upper() + return len(only_upper) \ No newline at end of file